Paths

Table of Contentst

[services-lib] Add method to upload blobs
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 5:20 PM.

Details

Reviewers

michal
• jon

Commits

rCOMMbff4ab0fddbf: [services-lib] Add method to upload blobs

Summary

Part of ENG-4597.

Added a function that takes a stream as an argument and uploads the data to blob service.

Depends on D8778

Test Plan

Tested together with next diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 10 2023, 5:20 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 5:20 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8780: [services-lib] Add methods to manage blob holders.Aug 10 2023, 5:27 PM

Harbormaster completed remote builds in B21695: Diff 29819.Aug 10 2023, 5:37 PM

bartek added inline comments.Aug 10 2023, 10:49 PM

services/comm-services-lib/src/blob/client.rs
140–142 ↗	(On Diff #29819)	Requirements of the reqwest body stream: A stream of `Result<impl Into<Vec<u8>>, impl Into<Box<dyn Error>>>`

bartek published this revision for review.Aug 11 2023, 9:20 AM

michal accepted this revision.Aug 11 2023, 11:35 AM

michal added inline comments.

services/comm-services-lib/src/blob/client.rs
144 ↗	(On Diff #29819)	Wrong message?

This revision is now accepted and ready to land.Aug 11 2023, 11:35 AM

Fix wrong log message

Harbormaster completed remote builds in B21792: Diff 29947.Aug 16 2023, 2:05 PM

Closed by commit rCOMMbff4ab0fddbf: [services-lib] Add method to upload blobs. · Explain WhyAug 16 2023, 2:25 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMbff4ab0fddbf: [services-lib] Add method to upload blobs.

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

blob/

client.rs

59 lines

Diff 29956

View Options

services/comm-services-lib/src/blob/client.rs

[services-lib] Add method to upload blobsClosedPublicActions