Page MenuHomePhabricator

[services-lib] Add HTTP client auth support
ClosedPublic

Authored by bartek on Aug 10 2023, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Wed, Oct 16, 3:10 PM
Unknown Object (File)
Oct 1 2024, 1:28 AM
Subscribers

Details

Summary

A proof of concept on how "User Identity" a.k.a commServicesAccessToken can be used with blob client

Depends on D8780.

Test Plan

TBD

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
services/comm-services-lib/src/blob/client.rs
327 ↗(On Diff #29829)

I'll change this expect to real error type later

services/comm-services-lib/src/auth.rs
26–29 ↗(On Diff #29829)

Nit: maybe let's import Engine and BASE64_STANDARD at the top

28 ↗(On Diff #29829)

I wonder if we should expect here and simplify the return type because I don't think if error happens here we could recover in any way that makes sense? UserIdentity should be serializable in all cases.

services/comm-services-lib/src/auth.rs
5–10 ↗(On Diff #29829)

Fields need to be public so other users can create this

Rebase, make with_user_identity() clone the client

bartek published this revision for review.Aug 28 2023, 2:32 AM
This revision is now accepted and ready to land.Aug 29 2023, 5:35 AM