This diff implements a struct that represents a row in the database. Also implemented conversions from/to attribute maps and other helper traits.
Depends on D8938
Details
Details
Tested later in the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/reports/src/database/item.rs | ||
|---|---|---|
| 99 ↗ | (On Diff #30300) | Might be nice to bring https://github.com/CommE2E/comm/blob/3bdda747deaf98f5d286ef586e5b2262d3481f95/services/identity/src/error.rs#L103 into comm-service-lib, then this would just be what's in the suggestion. However, this would be some additional effort. I guess make a ticket if you feel that it would be worthwhile. |
| services/reports/src/database/item.rs | ||
|---|---|---|
| 99 ↗ | (On Diff #30300) | Thanks for reminding me this! I think we can improve your helpers even further: pub trait AttributeExtractor { fn get_attr<T: TryFromAttribute>( &mut self, attribute_name: impl Into<String>, ) -> Result<T, DBItemError>; } impl AttributeExtractor for AttributeMap { fn get_attr<T: TryFromAttribute>( &mut self, attribute_name: impl Into<String>, ) -> Result<T, DBItemError> { let attribute_name = attribute_name.into(); T::try_from_attr(&attribute_name, self.remove(&attribute_name)) } } And now we can get any type that we implemented TryFromAttribute for: let some_string: String = value.get_attr("name")?; let boolean: bool = value.get_attr("boolAttribute")?; let nested_map: AttributeMap = value.get_attr("myMap")?; It's much better this way, thanks! I'll do it when having a while :gri |