Page MenuHomePhabricator

[reports-service] Send e-mails when received reports
ClosedPublic

Authored by bartek on Aug 28 2023, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Oct 2 2024, 12:09 PM
Unknown Object (File)
Sep 27 2024, 9:48 PM
Unknown Object (File)
Sep 11 2024, 5:14 PM
Unknown Object (File)
Sep 11 2024, 5:14 PM
Subscribers

Details

Summary

Final part of e-mail support stack that brings all the pieces together.

Depends on D8987

Test Plan

Set recipient to my local e-mail (with aliases for each report type: +inc, +media, +errors)
Found some real reports in my local MariaDB and sent them to Reports service. Checked my mailbox.
Example screenshots:

Screenshot 2023-08-29 at 08.53.03.png (1×1 px, 170 KB)
Screenshot 2023-08-29 at 08.40.39.png (1×1 px, 195 KB)
Screenshot 2023-08-28 at 10.31.10.png (1×1 px, 206 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Aug 29 2023, 12:23 AM
michal added inline comments.
services/reports/src/service.rs
108–113 ↗(On Diff #30465)

We could probably start sending emails before we start saving reports

This revision is now accepted and ready to land.Aug 29 2023, 9:55 AM
services/reports/src/service.rs
108–113 ↗(On Diff #30465)

I wanted to avoid this. If storing failed, then e-mails could have links to non-existing reports.

services/reports/src/service.rs
108–113 ↗(On Diff #30465)

Makes sense