[reports-service] Send e-mails when received reports
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 11:05 PM.

Details

Reviewers

michal
• patryk
• jon

Commits

rCOMM00e2ecda177b: [reports-service] Send e-mails when received reports

Summary

Final part of e-mail support stack that brings all the pieces together.

Depends on D8987

Test Plan

Set recipient to my local e-mail (with aliases for each report type: +inc, +media, +errors)
Found some real reports in my local MariaDB and sent them to Reports service. Checked my mailbox.
Example screenshots:

Screenshot 2023-08-29 at 08.53.03.png (1×1 px, 170 KB)

Screenshot 2023-08-29 at 08.40.39.png (1×1 px, 195 KB)

Screenshot 2023-08-28 at 10.31.10.png (1×1 px, 206 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 28 2023, 11:05 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 11:05 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B22189: Diff 30465.Aug 28 2023, 11:24 PM

bartek edited the summary of this revision. (Show Details)Aug 28 2023, 11:59 PM

bartek edited the test plan for this revision. (Show Details)

bartek attached a referenced file: F729073: Screenshot 2023-08-28 at 10.31.10.png. (Show Details)

bartek attached a referenced file: F729072: Screenshot 2023-08-29 at 08.40.39.png. (Show Details)

bartek attached a referenced file: F729071: Screenshot 2023-08-29 at 08.53.03.png. (Show Details)

bartek mentioned this in D8986: [reports-service] E-mail: inconsistency report details.Aug 29 2023, 12:04 AM

bartek mentioned this in D8985: [reports-service] E-mail: download links and JSON preview.Aug 29 2023, 12:07 AM

bartek mentioned this in D8984: [reports-service] E-mail subject and summary text.

bartek mentioned this in D8983: [reports-service] Introduce e-mail template.Aug 29 2023, 12:17 AM

bartek published this revision for review.Aug 29 2023, 12:23 AM

michal accepted this revision.Aug 29 2023, 9:55 AM

michal added inline comments.

services/reports/src/service.rs
108–113	We could probably start sending emails before we start saving reports

This revision is now accepted and ready to land.Aug 29 2023, 9:55 AM

bartek added inline comments.Aug 29 2023, 10:00 AM

services/reports/src/service.rs
108–113	I wanted to avoid this. If storing failed, then e-mails could have links to non-existing reports.

michal added inline comments.Aug 29 2023, 10:19 AM

services/reports/src/service.rs
108–113	Makes sense

bartek added a child revision: D9035: [reports-service] Encrypt reports.Aug 30 2023, 1:52 PM

Closed by commit rCOMM00e2ecda177b: [reports-service] Send e-mails when received reports (authored by bartek). · Explain WhySep 3 2023, 11:41 PM

This revision was automatically updated to reflect the committed changes.

bartek mentioned this in rCOMM8a4cb8ffa67b: [reports-service] Introduce e-mail template.

bartek mentioned this in rCOMM36fb6fbef848: [reports-service] E-mail subject and summary text.

bartek mentioned this in rCOMM2011bd7f7329: [reports-service] E-mail: download links and JSON preview.

bartek mentioned this in rCOMMd30c4df4513f: [reports-service] E-mail: inconsistency report details.

bartek added a commit: rCOMM00e2ecda177b: [reports-service] Send e-mails when received reports.

Revision Contents
Changeset List

Path

Size

services/

reports/

src/

database/

item.rs

38 lines

service.rs

78 lines

Diff 30465

View Options

services/reports/src/database/item.rs

Show First 20 Lines • Show All 733 Lines • ▼ Show 20 Lines	declare export type DrawerActionsType = {\|
...TabActionsType,		...TabActionsType,
+openDrawer: () => OpenDrawerAction,		+openDrawer: () => OpenDrawerAction,
+closeDrawer: () => CloseDrawerAction,		+closeDrawer: () => CloseDrawerAction,
+toggleDrawer: () => ToggleDrawerAction,		+toggleDrawer: () => ToggleDrawerAction,
\|};		\|};

declare export type DrawerRouterOptions = {\|		declare export type DrawerRouterOptions = {\|
...TabRouterOptions,		...TabRouterOptions,
+openByDefault?: boolean,		+defaultStatus?: 'open' \| 'closed',
\|};		\|};

/**		/**
* Events		* Events
*/		*/

declare export type EventMapBase = {		declare export type EventMapBase = {
+[name: string]: {\|		+[name: string]: {\|
▲ Show 20 Lines • Show All 1,212 Lines • ▼ Show 20 Lines	> = $Exact<NavigatorProps<
ExtraMaterialTopTabNavigatorProps,		ExtraMaterialTopTabNavigatorProps,
>>;		>>;

/**		/**
* Drawer options		* Drawer options
*/		*/

declare export type DrawerOptions = $Partial<{\|		declare export type DrawerOptions = $Partial<{\|
title: string,		+title: string,
drawerLabel:		+lazy: boolean,
		+drawerLabel:
\| string		\| string
\| ({\| +color: string, +focused: boolean \|}) => React$Node,		\| ({\| +color: string, +focused: boolean \|}) => React$Node,
drawerIcon: ({\|		+drawerIcon: ({\|
+color: string,		+color: string,
+size: number,		+size: number,
+focused: boolean,		+focused: boolean,
\|}) => React$Node,		\|}) => React$Node,
gestureEnabled: boolean,		+drawerActiveTintColor: string,
swipeEnabled: boolean,		+drawerActiveBackgroundColor: string,
unmountOnBlur: boolean,		+drawerInactiveTintColor: string,
		+drawerInactiveBackgroundColor: string,
		+drawerItemStyle: ViewStyleProp,
		+drawerLabelStyle: TextStyleProp,
		+drawerContentContainerStyle: ViewStyleProp,
		+drawerContentStyle: ViewStyleProp,
		+drawerStyle: ViewStyleProp,
		+drawerPosition: 'left' \| 'right',
		+drawerType: 'front' \| 'back' \| 'slide' \| 'permanent',
		+drawerHideStatusBarOnOpen: boolean,
		+drawerStatusBarAnimation: 'slide' \| 'none' \| 'fade',
		+overlayColor: string,
		+sceneContainerStyle: ViewStyleProp,
		+gestureHandlerProps: PanGestureHandlerProps,
		+swipeEnabled: boolean,
		+swipeEdgeWidth: number,
		+swipeMinDistance: number,
		+keyboardDismissMode: 'on-drag' \| 'none',
		+unmountOnBlur: boolean,
		+headerShown: boolean,
\|}>;		\|}>;

/**		/**
* Drawer navigation prop		* Drawer navigation prop
*/		*/

declare export type DrawerNavigationEventMap = {\|		declare export type DrawerNavigationEventMap =
...EventMapCore<DrawerNavigationState>,		EventMapCore<DrawerNavigationState>;
+drawerOpen: {\| +data: void, +canPreventDefault: false \|},
+drawerClose: {\| +data: void, +canPreventDefault: false \|},
\|};

declare type DrawerExtraNavigationHelpers<		declare type DrawerExtraNavigationHelpers<
ParamList: ParamListBase = ParamListBase,		ParamList: ParamListBase = ParamListBase,
> = {\|		> = {\|
+jumpTo: SimpleNavigate<ParamList>,		+jumpTo: SimpleNavigate<ParamList>,
+openDrawer: () => void,		+openDrawer: () => void,
+closeDrawer: () => void,		+closeDrawer: () => void,
+toggleDrawer: () => void,		+toggleDrawer: () => void,
Show All 32 Lines
* Miscellaneous drawer exports		* Miscellaneous drawer exports
*/		*/

declare export type DrawerDescriptor = Descriptor<		declare export type DrawerDescriptor = Descriptor<
DrawerNavigationHelpers<>,		DrawerNavigationHelpers<>,
DrawerOptions,		DrawerOptions,
>;		>;

declare export type DrawerItemListBaseOptions = $Partial<{\|
+activeTintColor: string,
+activeBackgroundColor: string,
+inactiveTintColor: string,
+inactiveBackgroundColor: string,
+itemStyle: ViewStyleProp,
+labelStyle: TextStyleProp,
\|}>;

declare export type DrawerContentOptions = $Partial<{\|
...DrawerItemListBaseOptions,
+contentContainerStyle: ViewStyleProp,
+style: ViewStyleProp,
\|}>;

declare type DrawerNavigationBuilderResult = {\|		declare type DrawerNavigationBuilderResult = {\|
+state: DrawerNavigationState,		+state: DrawerNavigationState,
+navigation: DrawerNavigationHelpers<>,		+navigation: DrawerNavigationHelpers<>,
+descriptors: {\| +[key: string]: DrawerDescriptor \|},		+descriptors: {\| +[key: string]: DrawerDescriptor \|},
\|};		\|};

declare export type DrawerContentProps = {\|
...DrawerContentOptions,
...DrawerNavigationBuilderResult,
+progress: any, // Reanimated.Node<number>
\|};

declare export type DrawerNavigationConfig = {\|		declare export type DrawerNavigationConfig = {\|
+drawerPosition?: 'left' \| 'right',		+drawerContent?: DrawerNavigationBuilderResult => React$Node,
+drawerType?: 'front' \| 'back' \| 'slide' \| 'permanent',
+edgeWidth?: number,
+hideStatusBar?: boolean,
+keyboardDismissMode?: 'on-drag' \| 'none',
+minSwipeDistance?: number,
+overlayColor?: string,
+statusBarAnimation?: 'slide' \| 'none' \| 'fade',
+gestureHandlerProps?: PanGestureHandlerProps,
+lazy?: boolean,
+drawerContent?: DrawerContentProps => React$Node,
+drawerContentOptions?: DrawerContentOptions,
+sceneContainerStyle?: ViewStyleProp,
+drawerStyle?: ViewStyleProp,
+detachInactiveScreens?: boolean,		+detachInactiveScreens?: boolean,
		+useLegacyImplementation?: boolean,
\|};		\|};

declare export type ExtraDrawerNavigatorProps = {\|		declare export type ExtraDrawerNavigatorProps = {\|
...$Exact<ExtraNavigatorPropsBase>,		...$Exact<ExtraNavigatorPropsBase>,
...DrawerRouterOptions,		...DrawerRouterOptions,
...DrawerNavigationConfig,		...DrawerNavigationConfig,
\|};		\|};

▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines