Page MenuHomePhabricator
Differential D8988

[reports-service] Send e-mails when received reports
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:19 AM
Unknown Object (File)
Mon, Nov 25, 2:20 AM
Unknown Object (File)
Mon, Nov 25, 12:21 AM
Unknown Object (File)
Oct 27 2024, 4:49 PM
Unknown Object (File)
Oct 27 2024, 4:49 PM
Unknown Object (File)
Oct 27 2024, 4:49 PM
Unknown Object (File)
Oct 27 2024, 4:46 PM
Unknown Object (File)
Oct 2 2024, 12:09 PM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• patryk
• jon
Commits
rCOMM00e2ecda177b: [reports-service] Send e-mails when received reports
Summary

Final part of e-mail support stack that brings all the pieces together.

Depends on D8987

Test Plan

Set recipient to my local e-mail (with aliases for each report type: +inc, +media, +errors)
Found some real reports in my local MariaDB and sent them to Reports service. Checked my mailbox.
Example screenshots:

Screenshot 2023-08-29 at 08.53.03.png (1×1 px, 170 KB)
Screenshot 2023-08-29 at 08.40.39.png (1×1 px, 195 KB)
Screenshot 2023-08-28 at 10.31.10.png (1×1 px, 206 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Aug 28 2023, 11:05 PM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 11:05 PM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B22189: Diff 30465.Aug 28 2023, 11:24 PM
bartek edited the summary of this revision. (Show Details)Aug 28 2023, 11:59 PM
bartek edited the test plan for this revision. (Show Details)
bartek attached a referenced file: F729073: Screenshot 2023-08-28 at 10.31.10.png. (Show Details)
bartek attached a referenced file: F729072: Screenshot 2023-08-29 at 08.40.39.png. (Show Details)
bartek attached a referenced file: F729071: Screenshot 2023-08-29 at 08.53.03.png. (Show Details)
bartek mentioned this in D8986: [reports-service] E-mail: inconsistency report details.Aug 29 2023, 12:04 AM
bartek mentioned this in D8985: [reports-service] E-mail: download links and JSON preview.Aug 29 2023, 12:07 AM
bartek mentioned this in D8984: [reports-service] E-mail subject and summary text.
bartek mentioned this in D8983: [reports-service] Introduce e-mail template.Aug 29 2023, 12:17 AM
bartek published this revision for review.Aug 29 2023, 12:23 AM
michal accepted this revision.Aug 29 2023, 9:55 AM
michal added inline comments.
services/reports/src/service.rs
108–113 ↗(On Diff #30465)

We could probably start sending emails before we start saving reports

This revision is now accepted and ready to land.Aug 29 2023, 9:55 AM
bartek added inline comments.Aug 29 2023, 10:00 AM
services/reports/src/service.rs
108–113 ↗(On Diff #30465)

I wanted to avoid this. If storing failed, then e-mails could have links to non-existing reports.

michal added inline comments.Aug 29 2023, 10:19 AM
services/reports/src/service.rs
108–113 ↗(On Diff #30465)

Makes sense

bartek added a child revision: D9035: [reports-service] Encrypt reports.Aug 30 2023, 1:52 PM
Closed by commit rCOMM00e2ecda177b: [reports-service] Send e-mails when received reports (authored by bartek). · Explain WhySep 3 2023, 11:41 PM
This revision was automatically updated to reflect the committed changes.
bartek mentioned this in rCOMM8a4cb8ffa67b: [reports-service] Introduce e-mail template.
bartek mentioned this in rCOMM36fb6fbef848: [reports-service] E-mail subject and summary text.
bartek mentioned this in rCOMM2011bd7f7329: [reports-service] E-mail: download links and JSON preview.
bartek mentioned this in rCOMMd30c4df4513f: [reports-service] E-mail: inconsistency report details.
bartek added a commit: rCOMM00e2ecda177b: [reports-service] Send e-mails when received reports.

Revision Contents
Changeset List

PathSize
services/
reports/
src/
database/
38 lines
79 lines

Diff 30725

View Options

services/reports/src/database/item.rs

Loading...
View Options

services/reports/src/service.rs

Loading...