[blob-service] DB: Add remaining client methods
AbandonedPublic
Actions

Authored by bartek on Jul 9 2023, 2:04 PM.

Details

Reviewers

michal
varun
• patryk
• jon

Summary

Part of ENG-4269.

Added methods to manage the unchecked status of database items - this will be used in the cleanup task in the future. Design is described in-depth in the notion doc attached to the parent linear issue.

Depends on D8451.

Test Plan

Tested together with the two previous diffs

Created a custom testing sandbox to play with these:

Checkout this stack
Apply this patch and copy the tests.rs file contents attached there to the services/blob/src/database/client/tests.rs.
cargo run

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 9 2023, 2:04 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:04 PM

bartek added a child revision: D8453: [blob-service] Create business logic abstraction.Jul 9 2023, 2:04 PM

Harbormaster completed remote builds in B20821: Diff 28508.Jul 9 2023, 2:24 PM

bartek edited the summary of this revision. (Show Details)Jul 9 2023, 11:01 PM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Jul 10 2023, 12:43 AM

rust LGTM, would like for someone else to take a look

I think BatchWriteItem needs to be called in a loop. We might also need to implement exponential backoff. More info here: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_BatchWriteItem.html

This revision now requires changes to proceed.Jul 13 2023, 10:16 AM

bartek removed a child revision: D8453: [blob-service] Create business logic abstraction.Jul 21 2023, 1:15 AM

The same as I mentioned in D8450, @varun is right - this needs a significant rework. Hopefully, we don't need these methods now - they will be used in the cleanup task which is not there yet so I excluded this from the core stack to unblock

bartek mentioned this in D8675: [Identity] Add DDB table for one-time-keys.Aug 3 2023, 11:17 PM

bartek mentioned this in D8894: [services-lib] Add DDB batch operation helpers.Aug 22 2023, 12:53 AM

bartek mentioned this in D8895: [services-lib] Add BatchWriteItem utility function.Aug 22 2023, 1:44 AM

bartek mentioned this in rCOMM902a52421098: [services-lib] Add DDB batch operation helpers.Aug 29 2023, 8:04 AM

bartek mentioned this in rCOMMa955e65db94e: [services-lib] Add BatchWriteItem utility function.

bartek mentioned this in D9349: [blob] Add db helpers for cleanup.Oct 4 2023, 3:00 AM

Replaced by D9349

bartek mentioned this in rCOMM57430669e460: [blob] Add db helpers for cleanup.Oct 16 2023, 1:40 AM