Page MenuHomePhabricator

[blob-service] DB: Add holder management methods
ClosedPublic

Authored by bartek on Jul 9 2023, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 6:12 PM
Unknown Object (File)
Fri, Nov 1, 6:11 PM
Unknown Object (File)
Fri, Nov 1, 6:11 PM
Unknown Object (File)
Fri, Nov 1, 6:11 PM
Unknown Object (File)
Fri, Nov 1, 5:47 PM
Unknown Object (File)
Mon, Oct 28, 1:35 AM
Unknown Object (File)
Sun, Oct 27, 4:34 PM
Unknown Object (File)
Sep 27 2024, 11:57 PM
Subscribers

Details

Summary

Part of ENG-4269.

Added methods to manage holder assignments - design described in-depth in the notion doc attached to the parent linear issue

Depends on D8450.

Test Plan

Tested together with the previous and the following diff

Created a custom testing sandbox to play with these:

  1. Checkout this stack (this + next diff)
  2. Apply this patch and copy the tests.rs file contents attached there to the services/blob/src/database/client/tests.rs.
  3. cargo run

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:43 AM

Rust looks fine to me, but would like other to take a look

services/blob/src/database/client.rs
156–157 ↗(On Diff #28507)

Should we create a followup task for this?

310 ↗(On Diff #28507)

Why are we checking if len < 3? Should we maybe put it into a more descriptive constant?

This revision is now accepted and ready to land.Jul 13 2023, 10:00 AM