Page MenuHomePhabricator
Differential D8458

[blob-service] Call service methods from handlers
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:07 PM.
Tags
None
Referenced Files
F2172794: D8458.id28917.diff
Tue, Jul 2, 8:41 PM
Unknown Object (File)
Sun, Jun 30, 11:17 AM
Unknown Object (File)
Tue, Jun 25, 10:01 PM
Unknown Object (File)
Tue, Jun 25, 7:04 PM
Unknown Object (File)
Tue, Jun 25, 3:35 AM
Unknown Object (File)
Tue, Jun 25, 3:35 AM
Unknown Object (File)
Tue, Jun 25, 3:35 AM
Unknown Object (File)
Tue, Jun 25, 3:34 AM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• patryk
• jon
Commits
rCOMM97d1c8d51329: [blob-service] Call service methods from handlers
Summary

Part of ENG-4269.

Replaced HTTP handlers logic with calls to the BlobService class

Depends on D8457.

Test Plan

Blob service integration and performance tests pass at this point.
Played with Postman to manually test the endpoints - both successful and failure cases (blob/holder not found, already exists, empty upload, invalid inputs)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jul 9 2023, 2:07 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:07 PM
bartek added a child revision: D8459: [blob-service] Delete old database code from http module.Jul 9 2023, 2:07 PM
Harbormaster completed remote builds in B20827: Diff 28514.Jul 9 2023, 2:59 PM
bartek edited the summary of this revision. (Show Details)Jul 10 2023, 12:09 AM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:45 AM
bartek added inline comments.
services/blob/src/http/handlers/blob.rs
1 ↗(On Diff #28514)

Will be removed in the next diff to avoid bloating this one

• jon resigned from this revision.Jul 10 2023, 6:19 PM

rust LGTM, would like for someone else to take a look

varun accepted this revision.Jul 12 2023, 4:05 PM
This revision is now accepted and ready to land.Jul 12 2023, 4:05 PM
bartek mentioned this in D8454: [blob-service] Implement download logic with new db.Jul 19 2023, 3:53 AM
bartek updated this revision to Diff 28917.Jul 21 2023, 1:53 AM

Rebase

Harbormaster completed remote builds in B21106: Diff 28917.Jul 21 2023, 3:11 AM
Closed by commit rCOMM97d1c8d51329: [blob-service] Call service methods from handlers (authored by bartek). · Explain WhyJul 25 2023, 1:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM97d1c8d51329: [blob-service] Call service methods from handlers.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
handlers/
259 lines

Diff 28997

View Options

services/blob/src/http/handlers/blob.rs

Loading...