Page MenuHomePhabricator

[blob-service] Call service methods from handlers
ClosedPublic

Authored by bartek on Jul 9 2023, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 2:03 AM
Unknown Object (File)
Fri, Nov 1, 5:52 PM
Unknown Object (File)
Fri, Nov 1, 5:50 PM
Unknown Object (File)
Fri, Nov 1, 5:47 PM
Unknown Object (File)
Fri, Nov 1, 5:47 PM
Unknown Object (File)
Fri, Nov 1, 5:27 PM
Unknown Object (File)
Sun, Oct 27, 4:35 PM
Unknown Object (File)
Oct 4 2024, 2:56 PM
Subscribers

Details

Summary

Part of ENG-4269.

Replaced HTTP handlers logic with calls to the BlobService class

Depends on D8457.

Test Plan

Blob service integration and performance tests pass at this point.
Played with Postman to manually test the endpoints - both successful and failure cases (blob/holder not found, already exists, empty upload, invalid inputs)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:45 AM
bartek added inline comments.
services/blob/src/http/handlers/blob.rs
1 ↗(On Diff #28514)

Will be removed in the next diff to avoid bloating this one

rust LGTM, would like for someone else to take a look

This revision is now accepted and ready to land.Jul 12 2023, 4:05 PM