Details
Details
Tested together with 2 following diffs
Created a custom testing sandbox to play with these:
- Checkout this stack (this + 2 next diffs)
- Apply this patch and copy the tests.rs file contents attached there to the services/blob/src/database/client/tests.rs.
- cargo run
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
otherwise the rest of the rust stuff looks fine to me.
Going to let varun check the DDB stuff
services/blob/src/database/client.rs | ||
---|---|---|
42–48 ↗ | (On Diff #28506) | Not the biggest fan of match, as it adds a lot of noise. However, the map style isn't much better. But I think is slightly more less noise. |
services/blob/src/database/client.rs | ||
---|---|---|
157 ↗ | (On Diff #28506) | don't we need to loop here in case not all the rows are returned? |
Comment Actions
Opted out of introducing batch methots for now - they require some more testing and changes.
Hopefully, we don't need them right now - they'll be used in the cleanup task.
I'll handle this in a separate diff later to unblock this stack.