[services][terraform] Add new blobs table definition
ClosedPublic
Actions

Authored by bartek on Jul 7 2023, 5:48 AM.

Details

Reviewers

michal
• jon
varun

Commits

rCOMM9ab2f6eb11dc: [services][terraform] Add new blobs table definition

Summary

Defined a new table for blobs in terraform, according to ENG-4267 design (Notion doc attached).

Also added constant names for the new table (I think it's easier to review when these are together).

Test Plan

terraform plan and apply.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 7 2023, 5:48 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 7 2023, 5:48 AM

bartek added a child revision: D8442: [blob-service] Introduce database types.Jul 7 2023, 6:01 AM

Harbormaster completed remote builds in B20793: Diff 28473.Jul 7 2023, 6:04 AM

bartek published this revision for review.Jul 7 2023, 7:03 AM

varun accepted this revision.Jul 9 2023, 8:22 AM

This revision is now accepted and ready to land.Jul 9 2023, 8:22 AM

Rebase

This revision was landed with ongoing or failed builds.Jul 21 2023, 12:33 AM

Closed by commit rCOMM9ab2f6eb11dc: [services][terraform] Add new blobs table definition (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9ab2f6eb11dc: [services][terraform] Add new blobs table definition.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

constants.rs

22 lines

terraform/

modules/

shared/

dynamodb.tf

36 lines

Diff 28905

View Options

services/blob/src/constants.rs

This file was added.

				// @flow

				import { useNavigation, useRoute } from '@react-navigation/native';
				import invariant from 'invariant';
				import * as React from 'react';
				import { View, TouchableOpacity } from 'react-native';

				import { userProfileUserInfoContainerHeight } from './user-profile-constants.js';
				import UserAvatar from '../avatars/user-avatar.react.js';
				import { OverlayContext } from '../navigation/overlay-context.js';
				import { UserProfileAvatarModalRouteName } from '../navigation/route-names.js';

				// We need to set onAvatarLayout in order to allow .measure() to be on the ref
				const onAvatarLayout = () => {};

				type Props = {
				userID: ?string,
				};

				function UserProfileAvatar(props: Props): React.Node {
				const { userID } = props;

				const { navigate } = useNavigation();
				const route = useRoute();

				const overlayContext = React.useContext(OverlayContext);

				const avatarRef = React.useRef();

				const onPressAvatar = React.useCallback(() => {
				invariant(overlayContext, 'UserProfileAvatar should have OverlayContext');
				overlayContext.setScrollBlockingModalStatus('open');

				const currentAvatarRef = avatarRef.current;
				if (!currentAvatarRef) {
				return;
				}

				currentAvatarRef.measure((x, y, width, height, pageX, pageY) => {
				const coordinates = {
				x: pageX,
				y: pageY,
				width,
				height,
				};

				const verticalBounds = {
				height: userProfileUserInfoContainerHeight,
				y: pageY,
				};

				navigate<'UserProfileAvatarModal'>({
				name: UserProfileAvatarModalRouteName,
				params: {
				presentedFrom: route.key,
				initialCoordinates: coordinates,
				verticalBounds,
				userID,
				},
				});
				});
				}, [navigate, overlayContext, route.key, userID]);

				return (
				<TouchableOpacity onPress={onPressAvatar}>
				<View ref={avatarRef} onLayout={onAvatarLayout}>
				<UserAvatar size="L" userID={userID} />
				</View>
				</TouchableOpacity>
				);
				}

				export default UserProfileAvatar;