Page MenuHomePhabricator
Differential D8438

[services-lib] Add integer and timestamp parsing helpers
ClosedPublic
Actions

Authored by bartek on Jul 7 2023, 5:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 12:27 AM
Unknown Object (File)
Fri, Mar 7, 6:07 PM
Unknown Object (File)
Fri, Mar 7, 6:06 PM
Unknown Object (File)
Fri, Mar 7, 6:06 PM
Unknown Object (File)
Fri, Mar 7, 6:06 PM
Unknown Object (File)
Fri, Mar 7, 6:01 PM
Unknown Object (File)
Feb 15 2025, 3:59 PM
Unknown Object (File)
Jan 11 2025, 6:30 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• patryk
• jon
varun
Commits
rCOMM4933f329fa0d: [services-lib] Add integer and timestamp parsing helpers
Summary

Adds a helper function to parse UTC timestamp DynamoDB attribute values.
Also improved the existing number parsing function to be more flexible
and renamed it to parse_integer because it was created specifically for integers

Test Plan

Unit tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
comm-services-lib/
src/
101 lines
feature-flags/
src/
2 lines

Diff 28904

View Options

services/comm-services-lib/src/database.rs

Show All 37 Linesexport type ClientDBReplaceCommunityOperation = {
+payload: ClientDBCommunityInfo, +payload: ClientDBCommunityInfo,
}; };
export type ClientDBCommunityStoreOperation = export type ClientDBCommunityStoreOperation =
| ClientDBReplaceCommunityOperation | ClientDBReplaceCommunityOperation
| RemoveCommunitiesOperation | RemoveCommunitiesOperation
| RemoveAllCommunitiesOperation; | RemoveAllCommunitiesOperation;
function convertCommunityInfoToClientDBCommunityInfo({
id,
communityInfo,
}: {
+id: string,
+communityInfo: CommunityInfo,
}): ClientDBCommunityInfo {
return {
id,
communityInfo: JSON.stringify(communityInfo),
};
}
const communityStoreOpsHandlers: BaseStoreOpsHandlers< const communityStoreOpsHandlers: BaseStoreOpsHandlers<
CommunityStore, CommunityStore,
CommunityStoreOperation, CommunityStoreOperation,
ClientDBCommunityStoreOperation, ClientDBCommunityStoreOperation,
CommunityInfos, CommunityInfos,
ClientDBCommunityInfo, ClientDBCommunityInfo,
> = { > = {
processStoreOperations( processStoreOperations(
Show All 30 Lines return ops.map(operation => {
operation.type === 'remove_communities' || operation.type === 'remove_communities' ||
operation.type === 'remove_all_communities' operation.type === 'remove_all_communities'
) { ) {
return operation; return operation;
} }
return { return {
type: 'replace_community', type: 'replace_community',
payload: { payload: convertCommunityInfoToClientDBCommunityInfo(operation.payload),
id: operation.payload.id,
communityInfo: JSON.stringify(operation.payload.communityInfo),
},
}; };
}); });
}, },
translateClientDBData( translateClientDBData(
communites: $ReadOnlyArray<ClientDBCommunityInfo>, communites: $ReadOnlyArray<ClientDBCommunityInfo>,
): CommunityInfos { ): CommunityInfos {
const communityInfos: { [id: string]: CommunityInfo } = {}; const communityInfos: { [id: string]: CommunityInfo } = {};
communites.forEach(dbCommunity => { communites.forEach(dbCommunity => {
communityInfos[dbCommunity.id] = JSON.parse(dbCommunity.communityInfo); communityInfos[dbCommunity.id] = JSON.parse(dbCommunity.communityInfo);
}); });
return communityInfos; return communityInfos;
}, },
}; };
export { communityStoreOpsHandlers }; export {
communityStoreOpsHandlers,
convertCommunityInfoToClientDBCommunityInfo,
};
View Options

services/feature-flags/src/database.rs

Show All 37 Linesexport type ClientDBReplaceCommunityOperation = {
+payload: ClientDBCommunityInfo, +payload: ClientDBCommunityInfo,
}; };
export type ClientDBCommunityStoreOperation = export type ClientDBCommunityStoreOperation =
| ClientDBReplaceCommunityOperation | ClientDBReplaceCommunityOperation
| RemoveCommunitiesOperation | RemoveCommunitiesOperation
| RemoveAllCommunitiesOperation; | RemoveAllCommunitiesOperation;
function convertCommunityInfoToClientDBCommunityInfo({
id,
communityInfo,
}: {
+id: string,
+communityInfo: CommunityInfo,
}): ClientDBCommunityInfo {
return {
id,
communityInfo: JSON.stringify(communityInfo),
};
}
const communityStoreOpsHandlers: BaseStoreOpsHandlers< const communityStoreOpsHandlers: BaseStoreOpsHandlers<
CommunityStore, CommunityStore,
CommunityStoreOperation, CommunityStoreOperation,
ClientDBCommunityStoreOperation, ClientDBCommunityStoreOperation,
CommunityInfos, CommunityInfos,
ClientDBCommunityInfo, ClientDBCommunityInfo,
> = { > = {
processStoreOperations( processStoreOperations(
Show All 30 Lines return ops.map(operation => {
operation.type === 'remove_communities' || operation.type === 'remove_communities' ||
operation.type === 'remove_all_communities' operation.type === 'remove_all_communities'
) { ) {
return operation; return operation;
} }
return { return {
type: 'replace_community', type: 'replace_community',
payload: { payload: convertCommunityInfoToClientDBCommunityInfo(operation.payload),
id: operation.payload.id,
communityInfo: JSON.stringify(operation.payload.communityInfo),
},
}; };
}); });
}, },
translateClientDBData( translateClientDBData(
communites: $ReadOnlyArray<ClientDBCommunityInfo>, communites: $ReadOnlyArray<ClientDBCommunityInfo>,
): CommunityInfos { ): CommunityInfos {
const communityInfos: { [id: string]: CommunityInfo } = {}; const communityInfos: { [id: string]: CommunityInfo } = {};
communites.forEach(dbCommunity => { communites.forEach(dbCommunity => {
communityInfos[dbCommunity.id] = JSON.parse(dbCommunity.communityInfo); communityInfos[dbCommunity.id] = JSON.parse(dbCommunity.communityInfo);
}); });
return communityInfos; return communityInfos;
}, },
}; };
export { communityStoreOpsHandlers }; export {
communityStoreOpsHandlers,
convertCommunityInfoToClientDBCommunityInfo,
};