Paths

Table of Contentst

[blob-service] Delete old database code from http module
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:07 PM.

Details

Reviewers

michal
varun
• patryk
• jon

Commits

rCOMM013d700586f9: [blob-service] Delete old database code from http module

Summary

Part of ENG-4269.

Removed all code related to the old database from the HTTP server part of the service. (gRPC still uses it).

Renamed http/context.rs to http/errors.rs because the only code left there is error handling.

Depends on D8458.

Test Plan

Blob service builds and runs, integration tests pass

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 9 2023, 2:07 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:07 PM

Harbormaster completed remote builds in B20828: Diff 28515.Jul 9 2023, 3:06 PM

bartek edited the summary of this revision. (Show Details)Jul 10 2023, 12:16 AM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Jul 10 2023, 12:46 AM

rust LGTM, would like for someone else to take a look

varun accepted this revision.Jul 11 2023, 2:06 PM

This revision is now accepted and ready to land.Jul 11 2023, 2:06 PM

Rebase

Harbormaster completed remote builds in B21107: Diff 28918.Jul 21 2023, 3:16 AM

Closed by commit rCOMM013d700586f9: [blob-service] Delete old database code from http module (authored by bartek). · Explain WhyJul 25 2023, 1:45 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM013d700586f9: [blob-service] Delete old database code from http module.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database/

client.rs

8 lines

http/

context.rs

	errors.rs
	context.rs

66 lines

handlers/

blob.rs

10 lines

mod.rs

20 lines

main.rs

2 lines

Diff 28998

View Options

services/blob/src/database/client.rs

View Options

services/blob/src/http/context.rs

View Options

services/blob/src/http/errors.rs

View Options

services/blob/src/http/handlers/blob.rs

View Options

services/blob/src/http/mod.rs

View Options

[blob-service] Delete old database code from http moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28998

services/blob/src/database/client.rs

services/blob/src/http/context.rs

services/blob/src/http/errors.rs

services/blob/src/http/handlers/blob.rs

services/blob/src/http/mod.rs

services/blob/src/main.rs

[blob-service] Delete old database code from http module
ClosedPublic
Actions

Revision Contents
Changeset List