Page MenuHomePhabricator
Differential D8455

[blob-service] Implement upload logic with new db
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 7:16 PM
Unknown Object (File)
Mon, Mar 17, 12:27 AM
Unknown Object (File)
Tue, Mar 11, 6:12 AM
Unknown Object (File)
Fri, Mar 7, 6:07 PM
Unknown Object (File)
Fri, Mar 7, 6:07 PM
Unknown Object (File)
Fri, Mar 7, 6:07 PM
Unknown Object (File)
Fri, Mar 7, 6:06 PM
Unknown Object (File)
Fri, Mar 7, 6:01 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• patryk
• jon
Commits
rCOMMbbc1d3685ac8: [blob-service] Implement upload logic with new db
Summary

Part of ENG-4269.

The code is mostly a copy-paste from http::handlers::blob::upload_blob_handler with the exception that it now accepts a stream instead of multipart form

Depends on D8454.

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jul 9 2023, 2:05 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:05 PM
bartek added a child revision: D8456: [blob-service] Implement holder management with new db.Jul 9 2023, 2:06 PM
Harbormaster completed remote builds in B20824: Diff 28511.Jul 9 2023, 2:40 PM
bartek edited the summary of this revision. (Show Details)Jul 9 2023, 11:43 PM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:44 AM
• jon resigned from this revision.Jul 10 2023, 6:20 PM

rust LGTM, would like for someone else to take a look

michal accepted this revision.Jul 17 2023, 2:01 AM
This revision is now accepted and ready to land.Jul 17 2023, 2:01 AM
bartek updated this revision to Diff 28914.Jul 21 2023, 1:53 AM

Rebase

Harbormaster completed remote builds in B21103: Diff 28914.Jul 21 2023, 2:44 AM
Closed by commit rCOMMbbc1d3685ac8: [blob-service] Implement upload logic with new db (authored by bartek). · Explain WhyJul 25 2023, 1:44 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMbbc1d3685ac8: [blob-service] Implement upload logic with new db.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
56 lines
11 lines

Diff 28994

View Options

services/blob/src/service.rs

  • This file was added.
// @flow
import { useNavigation, useRoute } from '@react-navigation/native';
import invariant from 'invariant';
import * as React from 'react';
import { View, TouchableOpacity } from 'react-native';
import { userProfileUserInfoContainerHeight } from './user-profile-constants.js';
import UserAvatar from '../avatars/user-avatar.react.js';
import { OverlayContext } from '../navigation/overlay-context.js';
import { UserProfileAvatarModalRouteName } from '../navigation/route-names.js';
// We need to set onAvatarLayout in order to allow .measure() to be on the ref
const onAvatarLayout = () => {};
type Props = {
userID: ?string,
};
function UserProfileAvatar(props: Props): React.Node {
const { userID } = props;
const { navigate } = useNavigation();
const route = useRoute();
const overlayContext = React.useContext(OverlayContext);
const avatarRef = React.useRef();
const onPressAvatar = React.useCallback(() => {
invariant(overlayContext, 'UserProfileAvatar should have OverlayContext');
overlayContext.setScrollBlockingModalStatus('open');
const currentAvatarRef = avatarRef.current;
if (!currentAvatarRef) {
return;
}
currentAvatarRef.measure((x, y, width, height, pageX, pageY) => {
const coordinates = {
x: pageX,
y: pageY,
width,
height,
};
const verticalBounds = {
height: userProfileUserInfoContainerHeight,
y: pageY,
};
navigate<'UserProfileAvatarModal'>({
name: UserProfileAvatarModalRouteName,
params: {
presentedFrom: route.key,
initialCoordinates: coordinates,
verticalBounds,
userID,
},
});
});
}, [navigate, overlayContext, route.key, userID]);
return (
<TouchableOpacity onPress={onPressAvatar}>
<View ref={avatarRef} onLayout={onAvatarLayout}>
<UserAvatar size="L" userID={userID} />
</View>
</TouchableOpacity>
);
}
export default UserProfileAvatar;
View Options

services/blob/src/tools.rs

  • This file was added.
// @flow
import { useNavigation, useRoute } from '@react-navigation/native';
import invariant from 'invariant';
import * as React from 'react';
import { View, TouchableOpacity } from 'react-native';
import { userProfileUserInfoContainerHeight } from './user-profile-constants.js';
import UserAvatar from '../avatars/user-avatar.react.js';
import { OverlayContext } from '../navigation/overlay-context.js';
import { UserProfileAvatarModalRouteName } from '../navigation/route-names.js';
// We need to set onAvatarLayout in order to allow .measure() to be on the ref
const onAvatarLayout = () => {};
type Props = {
userID: ?string,
};
function UserProfileAvatar(props: Props): React.Node {
const { userID } = props;
const { navigate } = useNavigation();
const route = useRoute();
const overlayContext = React.useContext(OverlayContext);
const avatarRef = React.useRef();
const onPressAvatar = React.useCallback(() => {
invariant(overlayContext, 'UserProfileAvatar should have OverlayContext');
overlayContext.setScrollBlockingModalStatus('open');
const currentAvatarRef = avatarRef.current;
if (!currentAvatarRef) {
return;
}
currentAvatarRef.measure((x, y, width, height, pageX, pageY) => {
const coordinates = {
x: pageX,
y: pageY,
width,
height,
};
const verticalBounds = {
height: userProfileUserInfoContainerHeight,
y: pageY,
};
navigate<'UserProfileAvatarModal'>({
name: UserProfileAvatarModalRouteName,
params: {
presentedFrom: route.key,
initialCoordinates: coordinates,
verticalBounds,
userID,
},
});
});
}, [navigate, overlayContext, route.key, userID]);
return (
<TouchableOpacity onPress={onPressAvatar}>
<View ref={avatarRef} onLayout={onAvatarLayout}>
<UserAvatar size="L" userID={userID} />
</View>
</TouchableOpacity>
);
}
export default UserProfileAvatar;