Page MenuHomePhabricator
Differential D8451

[blob-service] DB: Add holder management methods
ClosedPublic
Actions

Authored by bartek on Jul 9 2023, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 9:56 AM
Unknown Object (File)
Sat, Apr 19, 9:01 AM
Unknown Object (File)
Sat, Apr 19, 8:58 AM
Unknown Object (File)
Sat, Apr 19, 4:26 AM
Unknown Object (File)
Thu, Apr 17, 10:50 PM
Unknown Object (File)
Wed, Apr 2, 10:46 PM
Unknown Object (File)
Tue, Apr 1, 9:42 PM
Unknown Object (File)
Mar 19 2025, 3:22 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
• patryk
• jon
Commits
rCOMM9bc3ea4c0256: [blob-service] DB: Add holder management methods
Summary

Part of ENG-4269.

Added methods to manage holder assignments - design described in-depth in the notion doc attached to the parent linear issue

Depends on D8450.

Test Plan

Tested together with the previous and the following diff

Created a custom testing sandbox to play with these:

  1. Checkout this stack (this + next diff)
  2. Apply this patch and copy the tests.rs file contents attached there to the services/blob/src/database/client/tests.rs.
  3. cargo run

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jul 9 2023, 2:03 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2023, 2:03 PM
bartek added a child revision: D8452: [blob-service] DB: Add remaining client methods.Jul 9 2023, 2:04 PM
Harbormaster completed remote builds in B20820: Diff 28507.Jul 9 2023, 2:23 PM
bartek edited the summary of this revision. (Show Details)Jul 9 2023, 11:01 PM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jul 10 2023, 12:43 AM
• jon resigned from this revision.Jul 10 2023, 11:11 AM

Rust looks fine to me, but would like other to take a look

michal added inline comments.Jul 11 2023, 2:22 AM
services/blob/src/database/client.rs
156–157

Should we create a followup task for this?

310

Why are we checking if len < 3? Should we maybe put it into a more descriptive constant?

varun accepted this revision.Jul 13 2023, 10:00 AM
This revision is now accepted and ready to land.Jul 13 2023, 10:00 AM
bartek added a child revision: D8453: [blob-service] Create business logic abstraction.Jul 21 2023, 1:15 AM
bartek updated this revision to Diff 28911.Jul 21 2023, 1:52 AM

Rebase

Harbormaster completed remote builds in B21100: Diff 28911.Jul 21 2023, 2:21 AM
Closed by commit rCOMM9bc3ea4c0256: [blob-service] DB: Add holder management methods (authored by bartek). · Explain WhyJul 25 2023, 1:44 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9bc3ea4c0256: [blob-service] DB: Add holder management methods.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
database/
141 lines
4 lines

Diff 28507

View Options

services/blob/src/database/client.rs

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Linesfunction InviteLinkModal(props: Props): React.Node {
); );
const communityID = invitationDetails.community?.id; const communityID = invitationDetails.community?.id;
const createJoinCommunityAction = React.useCallback(async () => { const createJoinCommunityAction = React.useCallback(async () => {
invariant( invariant(
communityID, communityID,
'CommunityID should be present while calling this function', 'CommunityID should be present while calling this function',
); );
const query = calendarQuery(); const query = calendarQuery();
try {
const result = await callJoinThread({ const result = await callJoinThread({
threadID: communityID, threadID: communityID,
calendarQuery: { calendarQuery: {
startDate: query.startDate, startDate: query.startDate,
endDate: query.endDate, endDate: query.endDate,
filters: [ filters: [
...query.filters, ...query.filters,
{ type: 'threads', threadIDs: [communityID] }, { type: 'threads', threadIDs: [communityID] },
], ],
}, },
inviteLinkSecret: secret, inviteLinkSecret: secret,
}); });
props.navigation.goBack(); props.navigation.goBack();
return result; return result;
} catch (e) {
props.navigation.setParams({
invitationDetails: {
status: 'invalid',
},
secret,
});
throw e;
}
}, [calendarQuery, callJoinThread, communityID, props.navigation, secret]); }, [calendarQuery, callJoinThread, communityID, props.navigation, secret]);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const joinCommunity = React.useCallback(() => { const joinCommunity = React.useCallback(() => {
dispatchActionPromise(joinThreadActionTypes, createJoinCommunityAction()); dispatchActionPromise(joinThreadActionTypes, createJoinCommunityAction());
}, [createJoinCommunityAction, dispatchActionPromise]); }, [createJoinCommunityAction, dispatchActionPromise]);
const joinThreadLoadingStatus = useSelector(joinThreadLoadingStatusSelector); const joinThreadLoadingStatus = useSelector(joinThreadLoadingStatusSelector);
const buttons = React.useMemo(() => { const buttons = React.useMemo(() => {
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines
View Options

services/blob/src/database/errors.rs

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Linesfunction InviteLinkModal(props: Props): React.Node {
); );
const communityID = invitationDetails.community?.id; const communityID = invitationDetails.community?.id;
const createJoinCommunityAction = React.useCallback(async () => { const createJoinCommunityAction = React.useCallback(async () => {
invariant( invariant(
communityID, communityID,
'CommunityID should be present while calling this function', 'CommunityID should be present while calling this function',
); );
const query = calendarQuery(); const query = calendarQuery();
try {
const result = await callJoinThread({ const result = await callJoinThread({
threadID: communityID, threadID: communityID,
calendarQuery: { calendarQuery: {
startDate: query.startDate, startDate: query.startDate,
endDate: query.endDate, endDate: query.endDate,
filters: [ filters: [
...query.filters, ...query.filters,
{ type: 'threads', threadIDs: [communityID] }, { type: 'threads', threadIDs: [communityID] },
], ],
}, },
inviteLinkSecret: secret, inviteLinkSecret: secret,
}); });
props.navigation.goBack(); props.navigation.goBack();
return result; return result;
} catch (e) {
props.navigation.setParams({
invitationDetails: {
status: 'invalid',
},
secret,
});
throw e;
}
}, [calendarQuery, callJoinThread, communityID, props.navigation, secret]); }, [calendarQuery, callJoinThread, communityID, props.navigation, secret]);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const joinCommunity = React.useCallback(() => { const joinCommunity = React.useCallback(() => {
dispatchActionPromise(joinThreadActionTypes, createJoinCommunityAction()); dispatchActionPromise(joinThreadActionTypes, createJoinCommunityAction());
}, [createJoinCommunityAction, dispatchActionPromise]); }, [createJoinCommunityAction, dispatchActionPromise]);
const joinThreadLoadingStatus = useSelector(joinThreadLoadingStatusSelector); const joinThreadLoadingStatus = useSelector(joinThreadLoadingStatusSelector);
const buttons = React.useMemo(() => { const buttons = React.useMemo(() => {
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines