Page MenuHomePhabricator

[blob] Add db helpers for cleanup
ClosedPublic

Authored by bartek on Oct 4 2023, 3:00 AM.
Tags
None
Referenced Files
F2104431: D9349.id32016.diff
Tue, Jun 25, 5:01 AM
F2104430: D9349.id31785.diff
Tue, Jun 25, 5:01 AM
F2104429: D9349.id31621.diff
Tue, Jun 25, 5:01 AM
F2104380: D9349.id.diff
Tue, Jun 25, 5:00 AM
F2104328: D9349.diff
Tue, Jun 25, 4:53 AM
Unknown Object (File)
Sat, Jun 22, 2:27 PM
Unknown Object (File)
Sat, Jun 22, 7:35 AM
Unknown Object (File)
Sat, Jun 22, 1:46 AM
Subscribers

Details

Summary

This replaces D8452 - I have reimplemented these methods using new batch helpers. These functions are needed for blob cleanup.

Depends on D9348

Test Plan

Called these on a test dataset (containing combinations of checked and unchecked blobs and holders):

  • list_existing_keys - returns the same keys as given input if they exist in db. For a list of non-existing keys, an empty Vec is returned.
  • find_unchecked_items - confirmed that it returned only items that have unchecked attribute set.
  • batch_mark_checked - confirmed that items previously having checked attribute, no longer have it.
  • batch_delete_rows - confirmed that items are deleted from db.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable