Added a struct for representing unchecked items in database. It greatly simplifies the cleanup job.
It is used in the next two diffs
Depends on D9349
Details
Details
Code compiles, implementation is tested in the next two diffs.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/blob/src/service.rs | ||
|---|---|---|
| 232–235 ↗ | (On Diff #31786) | From looking at the later code it seems like we could just have: struct UncheckedItem {
has_hash: bool,
holders: Vec<String>,
};but it's fine the way it is now. If dynamodb allowed deletion with just partition key we could even just have has_holders: bool... |
| 277 ↗ | (On Diff #31786) | Can you add a comment (or a type alias) that explains what a String is in this case? |
| services/blob/src/service.rs | ||
|---|---|---|
| 232–235 ↗ | (On Diff #31786) | Theoretically yes, at some point I even considered that. However, I wanted each UncheckedItem to be independent: to contain full information about blob, regardless if it's inside or outside a map-like collection. |