[services-lib] Add function to batch get items
ClosedPublic
Actions

Authored by bartek on Oct 4 2023, 2:54 AM.

Details

Reviewers

michal
varun
• jon

Commits

rCOMMcdc3d6005803: [services-lib] Add function to batch get items

Summary

This is very similiar to D8895 but for getting items. It performs the BatchGetItem operation.

Test Plan

Locally, created a single-column table and filled it with values from 1 to 1000. Then ran the function to get them all. Confirmed that all 1000 items were returned. Logs confirmed that it was divided in batch of 100 items.
On staging, repeated the steps for a table with read capacity of 1. Confirmed that exponential backoff did the job and items were retrieved after a few retries. However, I needed to increase number of items to about 3k

In general, conclusions are similiar to D8895 test plan (this is expected, the code and working principle is analogous).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 4 2023, 2:54 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 4 2023, 2:54 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

bartek added a child revision: D9349: [blob] Add db helpers for cleanup.Oct 4 2023, 3:00 AM

Harbormaster completed remote builds in B22956: Diff 31620.Oct 4 2023, 3:12 AM

bartek published this revision for review.Oct 4 2023, 3:19 AM

Rebase. Remove unused import

Harbormaster completed remote builds in B23082: Diff 31784.Oct 9 2023, 5:51 AM

michal accepted this revision.Oct 10 2023, 2:33 AM

This revision is now accepted and ready to land.Oct 10 2023, 2:33 AM

Closed by commit rCOMMcdc3d6005803: [services-lib] Add function to batch get items (authored by bartek). · Explain WhyOct 16 2023, 1:40 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMcdc3d6005803: [services-lib] Add function to batch get items.

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

database.rs

126 lines

Diff 32015

View Options

services/comm-services-lib/src/database.rs

	Show All 22 Lines
	import createIDs from '../creators/id-creator.js';			import createIDs from '../creators/id-creator.js';
	import { dbQuery, SQL } from '../database/database.js';			import { dbQuery, SQL } from '../database/database.js';
	import type { SQLStatementType } from '../database/types.js';			import type { SQLStatementType } from '../database/types.js';
	import { validateOutput } from '../utils/validation-utils.js';			import { validateOutput } from '../utils/validation-utils.js';

	type ParsedDelivery = {			type ParsedDelivery = {
	+platform: 'ios' \| 'macos' \| 'android',			+platform: 'ios' \| 'macos' \| 'android',
	+codeVersion: ?number,			+codeVersion: ?number,
				+stateVersion: ?number,
	+notificationID: string,			+notificationID: string,
	+deviceTokens: $ReadOnlyArray<string>,			+deviceTokens: $ReadOnlyArray<string>,
	};			};

	type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };			type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };

	async function rescindPushNotifs(			async function rescindPushNotifs(
	notifCondition: SQLStatementType,			notifCondition: SQLStatementType,
	▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines

[services-lib] Add function to batch get itemsClosedPublicActions