services/blob/src/service.rs
232–235 ↗	(On Diff #31786)	From looking at the later code it seems like we could just have: struct UncheckedItem { has_hash: bool, holders: Vec<String>, }; but it's fine the way it is now. If dynamodb allowed deletion with just partition key we could even just have `has_holders: bool`...
277 ↗	(On Diff #31786)	Can you add a comment (or a type alias) that explains what a `String` is in this case?

This revision is now accepted and ready to land.Oct 10 2023, 6:09 AM

services/blob/src/service.rs
232–235 ↗	(On Diff #31786)	Theoretically yes, at some point I even considered that. However, I wanted each `UncheckedItem` to be independent: to contain full information about blob, regardless if it's inside or outside a map-like collection.

Address feedback: Add type alias for blob hash, use ref instead of cloning.

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

69 lines

Diff 31622

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };