Page MenuHomePhabricator

[reports-service] E-mail: inconsistency report details
ClosedPublic

Authored by bartek on Aug 28 2023, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 5:19 AM
Unknown Object (File)
Tue, Jun 11, 2:54 AM
Unknown Object (File)
Sat, Jun 8, 4:17 AM
Unknown Object (File)
Sun, May 26, 9:42 AM
Unknown Object (File)
Sun, May 26, 9:42 AM
Unknown Object (File)
Sun, May 26, 9:41 AM
Unknown Object (File)
Sun, May 26, 9:37 AM
Unknown Object (File)
Apr 4 2024, 1:39 PM
Subscribers

Details

Summary

Commbot messages for inconsistency reports have additional note about inconsistent fields. This diff reproduces this for report service emails.

Depends on D8985

Test Plan

Created a temporary HTTP endpoint that renders this HTML and opened it in the browser.
Screenshots of the final result in D8988

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek retitled this revision from [reports-service] Add inconsistency report utils to [reports-service] E-mail: inconsistency report details.Aug 28 2023, 11:08 PM
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Aug 29 2023, 12:22 AM
bartek added inline comments.
services/reports/src/report_utils.rs
7

This is a counterpart of this function

48

This is not implemented because I'd need to rewrite in Rust most of this file: https://github.com/CommE2E/comm/blob/a97c8af031b233112af53b1159e01aa602e4376a/lib/shared/entry-utils.js
I'll probably create a follow-up task

This revision is now accepted and ready to land.Aug 29 2023, 9:45 AM