Page MenuHomePhabricator
Differential D8975

[reports-service] Implement Blob storage
ClosedPublic
Actions

Authored by bartek on Aug 28 2023, 4:16 AM.
Tags
None
Referenced Files
F3188262: D8975.diff
Fri, Nov 8, 6:20 PM
Unknown Object (File)
Mon, Nov 4, 4:57 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:49 PM
Unknown Object (File)
Sun, Oct 27, 4:46 PM
Unknown Object (File)
Sat, Oct 12, 2:35 AM
View All 77 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• patryk
varun
• jon
tomek
Commits
rCOMM925742213d52: [reports-service] Implement Blob storage
Summary

Implemented storing large reports in blob service and retrieving them.

Depends on D8974, D8940

Test Plan

The plan requires D8971 to easily upload and view reports

  1. Commented out the size check to store all reports in blob service.
  2. Uploaded multiple reports. Verified that they are stored in blob service.
  3. Downloaded one report directly from blob service, using blob hash. When opened the file, it contained the report JSON.
  4. Viewed the report using report HTTP endpoint

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 28 2023, 4:16 AM
bartek held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 4:16 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
bartek published this revision for review.Aug 28 2023, 4:24 AM
Harbormaster completed remote builds in B22167: Diff 30433.Aug 28 2023, 4:34 AM
michal added a reviewer: tomek.Aug 29 2023, 9:05 AM

Adding @tomek because of new dependency while @ashoat is unavailable

But also sha2, seems much more popular than sha256. We use in commtest already

varun added a comment.Aug 29 2023, 11:53 AM
In D8975#265478, @michal wrote:

Adding @tomek because of new dependency while @ashoat is unavailable

But also sha2, seems much more popular than sha256. We use in commtest already

agreed we should use sha2 if possible

bartek planned changes to this revision.Aug 29 2023, 11:53 AM
bartek updated this revision to Diff 30520.Aug 29 2023, 12:59 PM

Use sha2 instead of sha256 for hashing

I'm not necessarily happy because in fact I had to add the hex too, previous library was more convenient :P Anyway, it works

Harbormaster completed remote builds in B22234: Diff 30520.Aug 29 2023, 1:18 PM
michal added 1 blocking reviewer(s): tomek.Aug 30 2023, 1:53 AM
tomek accepted this revision.Aug 30 2023, 2:10 AM

The dependency looks ok

This revision is now accepted and ready to land.Aug 30 2023, 2:10 AM
Closed by commit rCOMM925742213d52: [reports-service] Implement Blob storage (authored by bartek). · Explain WhyAug 31 2023, 4:50 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM925742213d52: [reports-service] Implement Blob storage.

Revision Contents
Changeset List

PathSize
services/
reports/
2 lines
src/
database/
32 lines

Diff 30520

View Options

services/reports/Cargo.lock

Loading...
View Options

services/reports/Cargo.toml

Loading...
View Options

services/reports/src/database/item.rs

Loading...