Page MenuHomePhabricator
Feed Advanced Search

Today

jon added a comment to D7130: [Identity] Add client device service to identity service.

feedback

Thu, Mar 23, 7:41 AM
jon updated the diff for D7130: [Identity] Add client device service to identity service.

ran -> run

Thu, Mar 23, 7:40 AM

Yesterday

jon updated the diff for D7130: [Identity] Add client device service to identity service.

rebase on master

Wed, Mar 22, 11:43 AM
jon updated the diff for D7116: [Comm-opaque2] Change project name to avoid name clash.

Rebase on master

Wed, Mar 22, 11:43 AM
jon added a comment to D7130: [Identity] Add client device service to identity service.

Address feedback

Wed, Mar 22, 11:42 AM
jon updated the diff for D7130: [Identity] Add client device service to identity service.

svc -> keyserver_service

Wed, Mar 22, 11:42 AM
jon added inline comments to D7130: [Identity] Add client device service to identity service.
Wed, Mar 22, 10:48 AM
jon requested review of D7130: [Identity] Add client device service to identity service.
Wed, Mar 22, 9:53 AM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Move prekey information to top-level message

Wed, Mar 22, 7:34 AM

Tue, Mar 21

jon requested review of D7116: [Comm-opaque2] Change project name to avoid name clash.
Tue, Mar 21, 12:51 PM
jon added inline comments to D7115: [Identity] Update X3DH protobuf to differiente key requests.
Tue, Mar 21, 12:23 PM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Expand comment on Sender / Receiver RPCs

Tue, Mar 21, 12:21 PM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Use Sender / Receiver as X3DH roles

Tue, Mar 21, 12:19 PM
jon resigned from D7105: Build files set-up for Android 13.

not very well versed in gradle, but please add me to cmake related stuff in the future :)

Tue, Mar 21, 10:02 AM

Mon, Mar 20

jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Fix what information is being requested by whom

Mon, Mar 20, 9:59 PM
jon requested review of D7115: [Identity] Update X3DH protobuf to differiente key requests.
Mon, Mar 20, 9:53 PM
jon added inline comments to D7113: [native] RustPromiseManager.
Mon, Mar 20, 9:44 PM
jon closed D7087: [Comm-opaque2] Add wasm build to client.
Mon, Mar 20, 8:50 PM
jon committed rCOMMfa13b21baf73: [Comm-opaque2] Add wasm build to client (authored by jon).
[Comm-opaque2] Add wasm build to client
Mon, Mar 20, 8:50 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

feedback

Mon, Mar 20, 3:22 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

typo

Mon, Mar 20, 3:17 PM
jon added inline comments to D7087: [Comm-opaque2] Add wasm build to client.
Mon, Mar 20, 10:03 AM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Address Feedback

Mon, Mar 20, 10:03 AM
jon closed D6722: [Android] Reference Tools by CMake project.
Mon, Mar 20, 7:45 AM
jon committed rCOMM6f883b5879f0: [Android] Reference Tools by CMake project (authored by jon).
[Android] Reference Tools by CMake project
Mon, Mar 20, 7:45 AM

Fri, Mar 17

jon closed D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Fri, Mar 17, 3:41 PM
jon committed rCOMM8751e77ed757: [comm-opaque] Create opaque 2.0 facade for usage in Comm (authored by jon).
[comm-opaque] Create opaque 2.0 facade for usage in Comm
Fri, Mar 17, 3:41 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Fri, Mar 17, 3:38 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

rlib -> lib

Fri, Mar 17, 2:38 PM

Thu, Mar 16

jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

This currently produces the outpus:

$ du -hd0 --apparent-size pkg/*
715	pkg/comm_opaque.d.ts
160	pkg/comm_opaque.js
14K	pkg/comm_opaque_bg.js
142K	pkg/comm_opaque_bg.wasm
1005	pkg/comm_opaque_bg.wasm.d.ts
249	pkg/package.json
Thu, Mar 16, 5:04 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

Add @ashoat because addtion of wasm-pack utility, and new usage of wasm_bindgen crate

Thu, Mar 16, 5:02 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Add back rlib for in-repo usage

Thu, Mar 16, 5:01 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Add wasm-pack to this diff

Thu, Mar 16, 5:00 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Move wasm-pack to wasm diff

Thu, Mar 16, 4:59 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 4:56 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Address feedback

Thu, Mar 16, 4:56 PM
jon requested review of D7087: [Comm-opaque2] Add wasm build to client.
Thu, Mar 16, 4:45 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 11:34 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Prune stale dependencies

Thu, Mar 16, 10:30 AM
jon retitled D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm from [comm-opaque] Create opaque facade for usage in Comm to [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 9:41 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Also assert that session_key was set in test

Thu, Mar 16, 9:37 AM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 9:31 AM
jon requested review of D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 9:22 AM
jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 9:16 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Remove sever_setup from constructors

Thu, Mar 16, 9:15 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Use opaque 2.0, remove server setup

Thu, Mar 16, 9:12 AM

Wed, Mar 15

jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service.

Wed, Mar 15, 9:04 PM

Tue, Mar 14

jon updated the test plan for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Tue, Mar 14, 8:15 PM
jon added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

I might move this code into shared/comm-opaque2, so that we can retain the opaque 1.2 Cipher definition as it is now and avoid having to tackle the migration immediately. Once we trigger the migration, we can just replace the 1.2 code once we are ready to migrate over to opaque 2.0.

Tue, Mar 14, 8:12 PM
jon closed D7062: [Identity] Add X3DH RPCs.
Tue, Mar 14, 7:59 PM
jon committed rCOMM265abf6197f0: [Identity] Add X3DH RPCs (authored by jon).
[Identity] Add X3DH RPCs
Tue, Mar 14, 7:59 PM
jon closed D7003: [Identity] Add client <-> identity protobuf defintions.
Tue, Mar 14, 7:59 PM
jon committed rCOMM3dc6c22047be: [Identity] Add client <-> identity protobuf defintions (authored by jon).
[Identity] Add client <-> identity protobuf defintions
Tue, Mar 14, 7:59 PM
jon added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Not going tackle updating to 2.0 in this diff, as all downstream usages of comm-opaque::Cipher (which is currently the entire code base) will need to be updated as well.

Tue, Mar 14, 2:46 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Expose facade as OOP

Tue, Mar 14, 2:40 PM
jon added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

Address feedback

Tue, Mar 14, 11:29 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Remove stream from update RPC, remove deviceEd27719 fields

Tue, Mar 14, 11:29 AM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Tue, Mar 14, 9:54 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

opaqueServerResponse -> opaqueLoginResponse

Tue, Mar 14, 9:39 AM
jon abandoned D7020: [comm-opaque] Add dependencies for client and server logic.

Going to merge into D7022

Tue, Mar 14, 9:33 AM
jon updated the diff for D6722: [Android] Reference Tools by CMake project.

Rebase on master

Tue, Mar 14, 9:31 AM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Have prekey refresh only pass prekeys and not onetime keys

Tue, Mar 14, 9:26 AM
jon added inline comments to D7062: [Identity] Add X3DH RPCs.
Tue, Mar 14, 9:26 AM
jon added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Tue, Mar 14, 9:20 AM

Mon, Mar 13

jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Use username or wallet ID for looking up keyserver info

Mon, Mar 13, 2:54 PM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Use userID to find KeyserverInfo

Mon, Mar 13, 1:14 PM
jon added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

For now, I renamed them all deviceEd25519PublicKey as I think that was the goal initially

Mon, Mar 13, 12:35 PM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

signingPublicKey -> deviceEd25519PublicKey

Mon, Mar 13, 12:34 PM
jon added inline comments to D7062: [Identity] Add X3DH RPCs.
Mon, Mar 13, 12:28 PM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Fix refreshPreKeys message. response -> upload

Mon, Mar 13, 12:28 PM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mon, Mar 13, 11:59 AM
jon requested review of D7003: [Identity] Add client <-> identity protobuf defintions.
Mon, Mar 13, 11:55 AM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mon, Mar 13, 11:55 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Split opaque RPCs into two unary RPCs

Mon, Mar 13, 11:48 AM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Correct KeyserverKeysResponse structure

Mon, Mar 13, 11:26 AM
jon requested review of D7062: [Identity] Add X3DH RPCs.
Mon, Mar 13, 10:43 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Limit diff to just account actions

Mon, Mar 13, 10:25 AM

Sun, Mar 12

jon added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Sun, Mar 12, 8:05 PM

Fri, Mar 10

jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Fri, Mar 10, 12:56 PM
jon added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

i don't love adding the dependencies in a separate diff, would like to see them added when they're actually being used

Fri, Mar 10, 10:42 AM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Fri, Mar 10, 10:26 AM
jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Going to go to a more OOP-like approach instead of some "static methods". Following https://github.com/marucjmar/opaque-wasm as an example of more ergonomic JS bindings.

Fri, Mar 10, 10:22 AM
jon closed D7028: [Identity] Change default port to 50054 to avoid port collision.
Fri, Mar 10, 9:22 AM
jon committed rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision (authored by jon).
[Identity] Change default port to 50054 to avoid port collision
Fri, Mar 10, 9:22 AM
jon updated the diff for D7028: [Identity] Change default port to 50054 to avoid port collision.

Rebase on master

Fri, Mar 10, 9:03 AM
jon added inline comments to D7028: [Identity] Change default port to 50054 to avoid port collision.
Fri, Mar 10, 9:00 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Address feedback:

  • clarify service comment
  • Make LoginPasswordUser into stream, and finalize OPAQUE
  • Remove GetUserID (at least for now, until we have a use case)
  • signingPublicKey -> deviceEd25519PublicKey
  • align opaque message with opaque_ke terms
Fri, Mar 10, 8:59 AM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Fri, Mar 10, 8:59 AM
jon added a comment to D7031: [CI] Fix macos buildkite ci.

looks fine to me, not going to accept so that atul can take a look as he's probably more familar with mac workflow.

Fri, Mar 10, 8:28 AM
jon updated the diff for D7028: [Identity] Change default port to 50054 to avoid port collision.

grpc -> gRPC

Fri, Mar 10, 8:27 AM

Thu, Mar 9

jon requested review of D7028: [Identity] Change default port to 50054 to avoid port collision.
Thu, Mar 9, 4:16 PM
jon closed D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
Thu, Mar 9, 3:27 PM
jon committed rCOMM538ca1cc8b28: [Identity] Rename IdentityService service to IdentityKeyserverService (authored by jon).
[Identity] Rename IdentityService service to IdentityKeyserverService
Thu, Mar 9, 3:27 PM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

UpdateUser -> UpdateUserPassword
Add comment on rpcs
Use a single "Empty" message instead of rpc specific versions

Thu, Mar 9, 3:21 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 9, 11:53 AM
jon added inline comments to D7020: [comm-opaque] Add dependencies for client and server logic.
Thu, Mar 9, 11:32 AM
jon requested review of D7020: [comm-opaque] Add dependencies for client and server logic.
Thu, Mar 9, 10:40 AM
jon requested review of D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 9, 10:40 AM

Wed, Mar 8

jon requested review of D7003: [Identity] Add client <-> identity protobuf defintions.
Wed, Mar 8, 6:54 PM
jon added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

Huh wait a user should know their userID, did you guys discard of the concept of a userID entirely because you didn't see it in the whitepaper?

Wed, Mar 8, 6:54 PM