[Identity] Improve VerifyUserAccessToken logging
ClosedPublic
Actions

Authored by • jon on Aug 22 2023, 10:41 AM.

Details

Reviewers

bartek
varun

Commits

rCOMMd3c3ab934b90: [Identity] Improve VerifyUserAccessToken logging

Summary

Was useful when tracking down where in this call something
was failing

In support of: https://linear.app/comm/issue/ENG-3977

Depends on D8891

Test Plan

Start identity service and tunnelbroker

cd services/commtest
cargo test --test identity_tunnelbroker_tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Aug 22 2023, 10:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 10:41 AM

• jon added a child revision: D8918: [Tunnelbroker] Authenticate connecting devices.Aug 22 2023, 10:46 AM

Harbormaster completed remote builds in B22024: Diff 30237.Aug 22 2023, 10:59 AM

• jon requested review of this revision.Aug 22 2023, 10:59 AM

bartek accepted this revision.Aug 22 2023, 12:10 PM

This revision is now accepted and ready to land.Aug 22 2023, 12:10 PM

Rebase on top of master

Harbormaster completed remote builds in B22110: Diff 30344.Aug 25 2023, 5:16 PM

Closed by commit rCOMMd3c3ab934b90: [Identity] Improve VerifyUserAccessToken logging (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMd3c3ab934b90: [Identity] Improve VerifyUserAccessToken logging.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

8 lines

Diff 30417

View Options

services/identity/src/client_service.rs

	// @flow			// @flow

	import type { TInterface } from 'tcomb';			import type { TInterface } from 'tcomb';
	import t from 'tcomb';			import t from 'tcomb';

	import { tShape, tString } from '../../utils/validation-utils.js';			import { tShape, tString } from '../../utils/validation-utils.js';

				type ConnectionInitializationSuccessStatus = { +type: 'Success' };
				type ConnectionInitializationErrorStatus = { +type: 'Error', +data: string };
	export type ConnectionInitializationStatus =			export type ConnectionInitializationStatus =
	\| { +type: 'Success' }			\| ConnectionInitializationSuccessStatus
	\| { +type: 'Error', +data: string };			\| ConnectionInitializationErrorStatus;

	const connectionInitializationStatusValidator = t.union([			const connectionInitializationStatusValidator = t.union([
	tShape({ type: tString('Success') }),			tShape<ConnectionInitializationSuccessStatus>({ type: tString('Success') }),
	tShape({ type: tString('Error'), data: t.String }),			tShape<ConnectionInitializationErrorStatus>({
				type: tString('Error'),
				data: t.String,
				}),
	]);			]);

	export type ConnectionInitializationResponse = {			export type ConnectionInitializationResponse = {
	+type: 'ConnectionInitializationResponse',			+type: 'ConnectionInitializationResponse',
	+status: ConnectionInitializationStatus,			+status: ConnectionInitializationStatus,
	};			};

	export const connectionInitializationResponseValidator: TInterface<ConnectionInitializationResponse> =			export const connectionInitializationResponseValidator: TInterface<ConnectionInitializationResponse> =
	tShape<ConnectionInitializationResponse>({			tShape<ConnectionInitializationResponse>({
	type: tString('ConnectionInitializationResponse'),			type: tString('ConnectionInitializationResponse'),
	status: connectionInitializationStatusValidator,			status: connectionInitializationStatusValidator,
	});			});

[Identity] Improve VerifyUserAccessToken loggingClosedPublicActions