Attempt to connect to tunnelbroker if available.
This is meant to be a "hello world" for establishing
a tunnelbroker connection.
Details
Details
- Reviewers
ashoat
(cd services/tunnelbroker && cargo run &) # should see message about db migration, then tunnelbroker message (cd keyserver && yarn dev)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Generally looks good, but requesting changes because I don't think we should land this "Hello world" example
| keyserver/package.json | ||
|---|---|---|
| 86 ↗ | (On Diff #26029) | Realizing this will change the version of ws that is imported here. In fact we're already importing a newer version (7.5.9) than our version of express-ws uses (5.2.3), but it looks like we only use it for Flow types so it's okay |
| keyserver/src/socket/tunnelbroker.js | ||
| 1 ↗ | (On Diff #26029) | Nit: add a newline after // @flow. In general, try to match conventions |
| 5–30 ↗ | (On Diff #26029) | I don't think we should land this stuff, but it's a good proof-of-concept. Should we update this diff to actually include changes we want to land now? |
| keyserver/src/keyserver.js | ||
|---|---|---|
| 67 ↗ | (On Diff #26076) | Do you mind if I just remove this call, and just build up the tunnelbroker support in the related tunnelbroker.js and types file? Would like to make some forward momentum, as constantly squashing the work will make for one large singular diff. |
| keyserver/src/socket/tunnelbroker.js | ||
| 5–30 ↗ | (On Diff #26029) | Was mostly looking to get good JS feedback, as that's still a big unknown for me. I can amend the other "finished" work once I'm able to do that. |
| keyserver/src/keyserver.js | ||
|---|---|---|
| 67 ↗ | (On Diff #26076) | Following our chat on Comm, is this still the plan? Let me know if so, otherwise passing back to you |
| keyserver/src/keyserver.js | ||
|---|---|---|
| 67 ↗ | (On Diff #26076) | Refactored out the blocking tunnelbroker work to avoid iterating through the JS commits as much. For clarity, the plan is now to progress is to land the whole stack once it's in a good spot. |
| keyserver/src/socket/tunnelbroker.js | ||
|---|---|---|
| 9–19 ↗ | (On Diff #26076) | Not a fan of accepting diffs with junk values, but I guess this is sort of like a "hello world" |