Attempt to connect to tunnelbroker if available.
This is meant to be a "hello world" for establishing
a tunnelbroker connection.
https://linear.app/comm/issue/ENG-3766
Depends on D8476
Differential D7691
[Keyserver] Open websocket connection with tunnelbroker kamil on Apr 30 2023, 10:58 PM. Authored by Tags None Referenced Files
Details Attempt to connect to tunnelbroker if available. https://linear.app/comm/issue/ENG-3766 Depends on D8476 (cd services/tunnelbroker && cargo run &) # should see message about db migration, then tunnelbroker message (cd keyserver && yarn dev)
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Comment Actions Address feedback
Comment Actions I got 15 lines into the file, and then gave up on the review due to frustration. You completely ignored a comment from my previous review. Please fix the issue, and then review all previous diff feedback carefully and thoroughly to make sure it has been addressed before putting this back on my diff queue.
Comment Actions You seem to have accidentally addressed my 2 comments from the previous review in D8752. Can you make sure you update this diff as well?
Comment Actions LGTM, mostly just a rename
|