Page MenuHomePhabricator
Differential D9128

[Tunnelbroker] match JS naming convention
ClosedPublic
Actions

Authored by kamil on Sep 11 2023, 8:14 AM.
Tags
None
Referenced Files
F5906710: D9128.diff
Thu, Apr 17, 2:18 PM
Unknown Object (File)
Thu, Mar 27, 3:56 AM
Unknown Object (File)
Mar 16 2025, 11:26 PM
Unknown Object (File)
Mar 16 2025, 11:26 PM
Unknown Object (File)
Mar 16 2025, 11:26 PM
Unknown Object (File)
Mar 16 2025, 11:25 PM
Unknown Object (File)
Mar 5 2025, 10:38 AM
Unknown Object (File)
Mar 3 2025, 8:46 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
michal
varun
• jon
Commits
rCOMMa5fbda1c676b: [Tunnelbroker] match JS naming convention
Summary

This was requested few times in the previous diffs.

Depends on: D8957

Test Plan
  • run test
  • check if keyserver can connect to Tunnelbroker

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
4 lines
lib/
types/
8 lines
services/
commtest/
tests/
6 lines
shared/
tunnelbroker_messages/
src/
messages/
3 lines
6 lines

Diff 31056

View Options

keyserver/src/socket/tunnelbroker.js

Show All 15 Lines
// TODO: flip the switch // TODO: flip the switch
const useBlobServiceUploads = false; const useBlobServiceUploads = false;
function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> { function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> {
const callUploadMultimedia = useServerCall(uploadMultimedia); const callUploadMultimedia = useServerCall(uploadMultimedia);
const callBlobServiceUpload = useBlobServiceUpload(); const callBlobServiceUpload = useBlobServiceUpload();
const uploadAvatarMedia = React.useCallback( const uploadAvatarMedia = React.useCallback(
async file => { async (file: File): Promise<UpdateUserAvatarRequest> => {
const validatedFile = await validateFile(file); const validatedFile = await validateFile(file);
const { result } = validatedFile; const { result } = validatedFile;
if (!result.success) { if (!result.success) {
throw new Error('Avatar media validation failed.'); throw new Error('Avatar media validation failed.');
} }
const { file: fixedFile, dimensions } = result; const { file: fixedFile, dimensions } = result;
const uploadExtras = { const uploadExtras = {
...dimensions, ...dimensions,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

lib/types/tunnelbroker-messages.js

Show All 15 Lines
// TODO: flip the switch // TODO: flip the switch
const useBlobServiceUploads = false; const useBlobServiceUploads = false;
function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> { function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> {
const callUploadMultimedia = useServerCall(uploadMultimedia); const callUploadMultimedia = useServerCall(uploadMultimedia);
const callBlobServiceUpload = useBlobServiceUpload(); const callBlobServiceUpload = useBlobServiceUpload();
const uploadAvatarMedia = React.useCallback( const uploadAvatarMedia = React.useCallback(
async file => { async (file: File): Promise<UpdateUserAvatarRequest> => {
const validatedFile = await validateFile(file); const validatedFile = await validateFile(file);
const { result } = validatedFile; const { result } = validatedFile;
if (!result.success) { if (!result.success) {
throw new Error('Avatar media validation failed.'); throw new Error('Avatar media validation failed.');
} }
const { file: fixedFile, dimensions } = result; const { file: fixedFile, dimensions } = result;
const uploadExtras = { const uploadExtras = {
...dimensions, ...dimensions,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

services/commtest/tests/tunnelbroker_integration_test.rs

Show All 15 Lines
// TODO: flip the switch // TODO: flip the switch
const useBlobServiceUploads = false; const useBlobServiceUploads = false;
function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> { function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> {
const callUploadMultimedia = useServerCall(uploadMultimedia); const callUploadMultimedia = useServerCall(uploadMultimedia);
const callBlobServiceUpload = useBlobServiceUpload(); const callBlobServiceUpload = useBlobServiceUpload();
const uploadAvatarMedia = React.useCallback( const uploadAvatarMedia = React.useCallback(
async file => { async (file: File): Promise<UpdateUserAvatarRequest> => {
const validatedFile = await validateFile(file); const validatedFile = await validateFile(file);
const { result } = validatedFile; const { result } = validatedFile;
if (!result.success) { if (!result.success) {
throw new Error('Avatar media validation failed.'); throw new Error('Avatar media validation failed.');
} }
const { file: fixedFile, dimensions } = result; const { file: fixedFile, dimensions } = result;
const uploadExtras = { const uploadExtras = {
...dimensions, ...dimensions,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

shared/tunnelbroker_messages/src/messages/keys.rs

Show All 15 Lines
// TODO: flip the switch // TODO: flip the switch
const useBlobServiceUploads = false; const useBlobServiceUploads = false;
function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> { function useUploadAvatarMedia(): File => Promise<UpdateUserAvatarRequest> {
const callUploadMultimedia = useServerCall(uploadMultimedia); const callUploadMultimedia = useServerCall(uploadMultimedia);
const callBlobServiceUpload = useBlobServiceUpload(); const callBlobServiceUpload = useBlobServiceUpload();
const uploadAvatarMedia = React.useCallback( const uploadAvatarMedia = React.useCallback(
async file => { async (file: File): Promise<UpdateUserAvatarRequest> => {
const validatedFile = await validateFile(file); const validatedFile = await validateFile(file);
const { result } = validatedFile; const { result } = validatedFile;
if (!result.success) { if (!result.success) {
throw new Error('Avatar media validation failed.'); throw new Error('Avatar media validation failed.');
} }
const { file: fixedFile, dimensions } = result; const { file: fixedFile, dimensions } = result;
const uploadExtras = { const uploadExtras = {
...dimensions, ...dimensions,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

shared/tunnelbroker_messages/src/messages/session.rs

Loading...