Paths

Table of Contentst

-
services/commtest/tests/
-
commtest/
-
tests/
-
identity_tunnelbroker_tests.rs

[Tunnelbroker] add authentication tests
ClosedPublic
Actions

Authored by kamil on Sep 14 2023, 3:10 AM.

Details

Reviewers

bartek
michal
varun
• jon

Commits

rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests

Summary

I implemented those to make sure D8918 works in both cases, so publishing, maybe will be helpful.

Depends on D8918

Test Plan

Start identity service, tunnelbroker

cd services/commtest
cargo test --test identity_tunnelbroker_tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 14 2023, 3:10 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 14 2023, 3:10 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

kamil published this revision for review.Sep 14 2023, 3:20 AM

Harbormaster completed remote builds in B22626: Diff 31123.Sep 14 2023, 3:28 AM

bartek accepted this revision.Sep 14 2023, 3:39 AM

bartek added inline comments.

services/commtest/tests/identity_tunnelbroker_tests.rs
45 ↗	(On Diff #31123)	Nit: Are these `unwrap`s hiding some meaningful error? It's usually a good practice to use `expect("error message")` instead. This way if this fails, we at least know what exactly failed. Otherwise, error messages are rather vague.

This revision is now accepted and ready to land.Sep 14 2023, 3:39 AM

michal accepted this revision.Sep 14 2023, 3:41 AM

unwrap -> expect

Harbormaster completed remote builds in B22630: Diff 31127.Sep 14 2023, 4:16 AM

Closed by commit rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests (authored by kamil). · Explain WhySep 14 2023, 5:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

identity_tunnelbroker_tests.rs

66 lines

Diff 31130

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

	Show All 22 Lines
	import createIDs from '../creators/id-creator.js';			import createIDs from '../creators/id-creator.js';
	import { dbQuery, SQL } from '../database/database.js';			import { dbQuery, SQL } from '../database/database.js';
	import type { SQLStatementType } from '../database/types.js';			import type { SQLStatementType } from '../database/types.js';
	import { validateOutput } from '../utils/validation-utils.js';			import { validateOutput } from '../utils/validation-utils.js';

	type ParsedDelivery = {			type ParsedDelivery = {
	+platform: 'ios' \| 'macos' \| 'android',			+platform: 'ios' \| 'macos' \| 'android',
	+codeVersion: ?number,			+codeVersion: ?number,
				+stateVersion: ?number,
	+notificationID: string,			+notificationID: string,
	+deviceTokens: $ReadOnlyArray<string>,			+deviceTokens: $ReadOnlyArray<string>,
	};			};

	type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };			type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };

	async function rescindPushNotifs(			async function rescindPushNotifs(
	notifCondition: SQLStatementType,			notifCondition: SQLStatementType,
	▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines

[Tunnelbroker] add authentication testsClosedPublicActions