Page MenuHomePhabricator
Differential D8957

[Keyserver] Use getCommConfig for tunnelbroker connection
ClosedPublic
Actions

Authored by kamil on Aug 25 2023, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 11:37 PM
Unknown Object (File)
Tue, Apr 16, 7:50 AM
Unknown Object (File)
Mon, Apr 15, 4:05 PM
Unknown Object (File)
Mon, Apr 15, 12:26 AM
Unknown Object (File)
Sun, Apr 14, 11:54 PM
Unknown Object (File)
Sun, Apr 14, 11:44 PM
Unknown Object (File)
Sat, Apr 13, 4:03 PM
Unknown Object (File)
Fri, Apr 12, 6:24 PM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
• jon
ashoat
Commits
rCOMMc62d949459d0: [Keyserver] Use getCommConfig for tunnelbroker connection
Summary

Allow for the tunnelbroker endpoint to be configured. Necessary
for targeting production or staging instance during deployments.

https://linear.app/comm/issue/ENG-4706

Depends on D8956

Test Plan
cd keyserver
yarn dev # Should say defaulting to local instance
export COMM_JSONCONFIG_facts_tunnelbroker="{\"url\":\"ws://127.0.0.1:51001\"}"
yarn dev # Should omit default message, still connect to local instance

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Aug 25 2023, 1:00 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 25 2023, 1:00 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 25 2023, 1:13 PM
Harbormaster failed remote builds in B22098: Diff 30332!
• jon updated this revision to Diff 30337.Aug 25 2023, 3:42 PM

Rebase on prev diff fixes

Harbormaster completed remote builds in B22103: Diff 30337.Aug 25 2023, 3:58 PM
• jon requested review of this revision.Aug 25 2023, 3:58 PM
marcin accepted this revision.Aug 28 2023, 8:25 AM
This revision is now accepted and ready to land.Aug 28 2023, 8:25 AM
• jon added a reviewer: ashoat.Aug 30 2023, 1:01 PM
This revision now requires review to proceed.Aug 30 2023, 1:01 PM
ashoat accepted this revision.Sep 6 2023, 6:13 PM
ashoat added inline comments.
keyserver/src/socket/tunnelbroker.js
44 ↗(On Diff #30337)

Can this be done in parallel instead of waiting for the await on line 42 to complete

This revision is now accepted and ready to land.Sep 6 2023, 6:13 PM
ashoat commandeered this revision.Sep 6 2023, 6:13 PM
ashoat edited reviewers, added: • jon; removed: ashoat.
ashoat foisted this revision upon kamil.
ashoat edited reviewers, added: ashoat; removed: kamil.

@kamil, would you mind taking over this diff, addressing my inline comment, and landing it?

kamil added a comment.Sep 8 2023, 10:32 AM
In D8957#267890, @ashoat wrote:

@kamil, would you mind taking over this diff, addressing my inline comment, and landing it?

Sure, I'll address the comment before landing

kamil mentioned this in D9128: [Tunnelbroker] match JS naming convention.Sep 11 2023, 8:14 AM
kamil added a child revision: D9128: [Tunnelbroker] match JS naming convention.Sep 11 2023, 8:31 AM
kamil updated this revision to Diff 31045.Sep 13 2023, 7:02 AM
  • address review
  • review before landing
Harbormaster completed remote builds in B22587: Diff 31045.Sep 13 2023, 7:20 AM
Closed by commit rCOMMc62d949459d0: [Keyserver] Use getCommConfig for tunnelbroker connection (authored by kamil). · Explain WhySep 13 2023, 7:21 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc62d949459d0: [Keyserver] Use getCommConfig for tunnelbroker connection.
kamil mentioned this in rCOMMa5fbda1c676b: [Tunnelbroker] match JS naming convention.Sep 13 2023, 8:37 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
31 lines

Diff 31046

View Options

keyserver/src/socket/tunnelbroker.js

Loading...