Allow for the tunnelbroker endpoint to be configured. Necessary
for targeting production or staging instance during deployments.
https://linear.app/comm/issue/ENG-4706
Depends on D8956
Details
Details
cd keyserver
yarn dev # Should say defaulting to local instance
export COMM_JSONCONFIG_facts_tunnelbroker="{\"url\":\"ws://127.0.0.1:51001\"}"
yarn dev # Should omit default message, still connect to local instanceDiff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/socket/tunnelbroker.js | ||
|---|---|---|
| 44 ↗ | (On Diff #30337) | Can this be done in parallel instead of waiting for the await on line 42 to complete |
Comment Actions
@kamil, would you mind taking over this diff, addressing my inline comment, and landing it?