Page MenuHomePhabricator
Differential D8917

[shared/grpc_clients] Export tonic to avoid version mismatch
ClosedPublic
Actions

Authored by • jon on Aug 22 2023, 10:43 AM.
Tags
None
Referenced Files
F5899994: D8917.id30273.diff
Thu, Apr 17, 12:16 PM
F5896375: D8917.id30238.diff
Thu, Apr 17, 11:04 AM
F5893287: D8917.id.diff
Thu, Apr 17, 9:08 AM
Unknown Object (File)
Thu, Apr 17, 1:00 AM
Unknown Object (File)
Thu, Apr 17, 12:42 AM
Unknown Object (File)
Wed, Apr 16, 9:13 AM
Unknown Object (File)
Sat, Mar 29, 9:38 PM
Unknown Object (File)
Mar 16 2025, 11:05 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMa97c8af031b2: [shared/grpc_clients] Export tonic to avoid version mismatch
Summary

If the consuming crate has a different version, then you will
get compilation errors when mismatching the different tonic versions.
Export tonic from grpc_clients to avoid this issues.

Also explicitly state that the build.rs should be re-ran if a proto
changes.

In support of https://linear.app/comm/issue/ENG-3977

Depends on D8891

Test Plan

Applied in next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
3 lines
4 lines
shared/
grpc_clients/
4 lines
src/
3 lines

Diff 30418

View Options

services/tunnelbroker/Dockerfile

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/make_docker_image.sh

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

shared/grpc_clients/build.rs

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

shared/grpc_clients/src/lib.rs

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines