Page MenuHomePhabricator

[shared/grpc_clients] Export tonic to avoid version mismatch
ClosedPublic

Authored by jon on Aug 22 2023, 10:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 12:19 PM
Unknown Object (File)
Mon, Nov 11, 11:33 AM
Unknown Object (File)
Wed, Oct 30, 2:38 AM
Unknown Object (File)
Sun, Oct 27, 2:54 AM
Unknown Object (File)
Sun, Oct 27, 2:54 AM
Unknown Object (File)
Sun, Oct 27, 2:54 AM
Unknown Object (File)
Sun, Oct 27, 2:54 AM
Unknown Object (File)
Sun, Oct 27, 2:54 AM
Subscribers

Details

Summary

If the consuming crate has a different version, then you will
get compilation errors when mismatching the different tonic versions.
Export tonic from grpc_clients to avoid this issues.

Also explicitly state that the build.rs should be re-ran if a proto
changes.

In support of https://linear.app/comm/issue/ENG-3977

Depends on D8891

Test Plan

Applied in next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable