Page MenuHomePhabricator
Differential D8891

[Identity] Adopt TLS-enabled tunnelbroker client
ClosedPublic
Actions

Authored by • jon on Aug 21 2023, 6:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 3:41 AM
Unknown Object (File)
Sun, Mar 16, 11:04 PM
Unknown Object (File)
Wed, Mar 12, 1:28 AM
Unknown Object (File)
Tue, Mar 11, 10:36 PM
Unknown Object (File)
Wed, Mar 5, 1:40 AM
Unknown Object (File)
Wed, Mar 5, 1:22 AM
Unknown Object (File)
Tue, Mar 4, 10:44 PM
Unknown Object (File)
Tue, Mar 4, 7:35 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM9563d223292e: [Identity] Adopt TLS-enabled tunnelbroker client
Summary

Use TLS-enabled tunnelbroker client from identity service.

https://linear.app/comm/issue/ENG-4641

Depends on D8890

Test Plan
  • Start identity service, tunnelbroker
cd services/commtest
cargo test --test identity_tunnelbroker_tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Aug 21 2023, 6:59 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 21 2023, 6:59 AM
Harbormaster completed remote builds in B21947: Diff 30144.Aug 21 2023, 7:17 AM
• jon requested review of this revision.Aug 21 2023, 7:17 AM
bartek accepted this revision.Aug 22 2023, 12:30 AM
This revision is now accepted and ready to land.Aug 22 2023, 12:30 AM
• jon added a child revision: D8916: [Identity] Improve VerifyUserAccessToken logging.Aug 22 2023, 10:41 AM
• jon added a child revision: D8917: [shared/grpc_clients] Export tonic to avoid version mismatch.
• jon updated this revision to Diff 30269.Aug 23 2023, 9:31 AM

Add missed changes

Harbormaster completed remote builds in B22049: Diff 30269.Aug 23 2023, 9:49 AM
• jon updated this revision to Diff 30343.Aug 25 2023, 4:53 PM

Rebase on top of master

Harbormaster completed remote builds in B22109: Diff 30343.Aug 25 2023, 5:12 PM
Closed by commit rCOMM9563d223292e: [Identity] Adopt TLS-enabled tunnelbroker client (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM9563d223292e: [Identity] Adopt TLS-enabled tunnelbroker client.

Revision Contents
Changeset List

PathSize
services/
identity/
1 line
7 lines
src/
14 lines

Diff 30416

View Options

services/identity/Cargo.lock

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

services/identity/Cargo.toml

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

services/identity/build.rs

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

services/identity/src/tunnelbroker.rs

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };