Page MenuHomePhabricator
Differential D8607

[Identity] Refactor DB error logic
ClosedPublic
Actions

Authored by • jon on Jul 24 2023, 6:54 AM.
Tags
None
Referenced Files
F5924396: D8607.id28972.diff
Thu, Apr 17, 11:46 PM
F5921956: D8607.id.diff
Thu, Apr 17, 10:58 PM
F5916194: D8607.id29029.diff
Thu, Apr 17, 9:03 PM
F5901196: D8607.diff
Thu, Apr 17, 12:37 PM
Unknown Object (File)
Tue, Apr 15, 5:30 AM
Unknown Object (File)
Mar 18 2025, 5:24 PM
Unknown Object (File)
Mar 17 2025, 12:27 AM
Unknown Object (File)
Mar 7 2025, 10:48 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMe2d369186e97: [Identity] Refactor DB error logic
Summary

Since this needs to be called for both the authenticated
and unauthenticated service, we should move to it's own module.

Done in support of: https://linear.app/comm/issue/ENG-4445

Depends on D8606

Test Plan
cd identity && cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jul 24 2023, 6:54 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 6:54 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 7:00 AM
Harbormaster failed remote builds in B21150: Diff 28972!
• jon updated this revision to Diff 29029.Jul 25 2023, 10:42 AM

Rebase on fixes

• jon added a child revision: D8627: [Identity] Remove static lifetime constraint on DBItemError.Jul 25 2023, 10:44 AM
Harbormaster completed remote builds in B21193: Diff 29029.Jul 26 2023, 6:20 PM
• jon requested review of this revision.Jul 26 2023, 6:20 PM
bartek accepted this revision.Jul 27 2023, 6:35 AM

Good idea, I did the same in blob service

This revision is now accepted and ready to land.Jul 27 2023, 6:35 AM
Closed by commit rCOMMe2d369186e97: [Identity] Refactor DB error logic (authored by • jon). · Explain WhyAug 8 2023, 9:00 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMe2d369186e97: [Identity] Refactor DB error logic.
• jon mentioned this in D8765: [identity] more helpers for identity service.Aug 9 2023, 5:36 PM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
3 lines
51 lines
51 lines
1 line

Diff 29627

View Options

services/identity/src/client_service.rs

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

services/identity/src/error.rs

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

services/identity/src/main.rs

Show All 22 Lines
import createIDs from '../creators/id-creator.js'; import createIDs from '../creators/id-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import type { SQLStatementType } from '../database/types.js'; import type { SQLStatementType } from '../database/types.js';
import { validateOutput } from '../utils/validation-utils.js'; import { validateOutput } from '../utils/validation-utils.js';
type ParsedDelivery = { type ParsedDelivery = {
+platform: 'ios' | 'macos' | 'android', +platform: 'ios' | 'macos' | 'android',
+codeVersion: ?number, +codeVersion: ?number,
+stateVersion: ?number,
+notificationID: string, +notificationID: string,
+deviceTokens: $ReadOnlyArray<string>, +deviceTokens: $ReadOnlyArray<string>,
}; };
type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> }; type ParsedDeliveries = { +[id: string]: $ReadOnlyArray<ParsedDelivery> };
async function rescindPushNotifs( async function rescindPushNotifs(
notifCondition: SQLStatementType, notifCondition: SQLStatementType,
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines