Page MenuHomePhabricator
Differential D8607

[Identity] Refactor DB error logic
ClosedPublic
Actions

Authored by • jon on Jul 24 2023, 6:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 9:25 PM
Unknown Object (File)
Tue, Apr 30, 1:46 AM
Unknown Object (File)
Sun, Apr 28, 12:16 AM
Unknown Object (File)
Thu, Apr 25, 1:58 PM
Unknown Object (File)
Tue, Apr 16, 7:50 AM
Unknown Object (File)
Tue, Apr 16, 3:21 AM
Unknown Object (File)
Mon, Apr 15, 11:51 PM
Unknown Object (File)
Sun, Apr 14, 11:44 PM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMe2d369186e97: [Identity] Refactor DB error logic
Summary

Since this needs to be called for both the authenticated
and unauthenticated service, we should move to it's own module.

Done in support of: https://linear.app/comm/issue/ENG-4445

Depends on D8606

Test Plan
cd identity && cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jul 24 2023, 6:54 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 6:54 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2023, 7:00 AM
Harbormaster failed remote builds in B21150: Diff 28972!
• jon updated this revision to Diff 29029.Jul 25 2023, 10:42 AM

Rebase on fixes

• jon added a child revision: D8627: [Identity] Remove static lifetime constraint on DBItemError.Jul 25 2023, 10:44 AM
Harbormaster completed remote builds in B21193: Diff 29029.Jul 26 2023, 6:20 PM
• jon requested review of this revision.Jul 26 2023, 6:20 PM
bartek accepted this revision.Jul 27 2023, 6:35 AM

Good idea, I did the same in blob service

This revision is now accepted and ready to land.Jul 27 2023, 6:35 AM
Closed by commit rCOMMe2d369186e97: [Identity] Refactor DB error logic (authored by • jon). · Explain WhyAug 8 2023, 9:00 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMe2d369186e97: [Identity] Refactor DB error logic.
• jon mentioned this in D8765: [identity] more helpers for identity service.Aug 9 2023, 5:36 PM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
3 lines
51 lines
51 lines
1 line

Diff 29029

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/error.rs

Loading...
View Options

services/identity/src/main.rs

Loading...