[Identity] Remove static lifetime constraint on DBItemError
ClosedPublic
Actions

Authored by • jon on Jul 25 2023, 5:44 PM.

Details

Reviewers

bartek
varun

Commits

rCOMM83836ecf16b7: [Identity] Remove static lifetime constraint on DBItemError

Summary

In order to support device maps, we can't assume
that all attribute keys will be known staticly.

In support of https://linear.app/comm/issue/ENG-4445

Depends on D8607

Test Plan

cd identity && cargo build

or run any integration tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 25 2023, 5:44 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2023, 5:44 PM

Harbormaster completed remote builds in B21194: Diff 29030.Jul 25 2023, 6:11 PM

• jon requested review of this revision.Jul 25 2023, 6:11 PM

varun accepted this revision.Jul 25 2023, 7:41 PM

This revision is now accepted and ready to land.Jul 25 2023, 7:41 PM

• jon added a child revision: D8642: Allow for devices to register as a keyserver.Jul 27 2023, 12:37 AM

Closed by commit rCOMM83836ecf16b7: [Identity] Remove static lifetime constraint on DBItemError. · Explain WhyAug 8 2023, 4:01 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM83836ecf16b7: [Identity] Remove static lifetime constraint on DBItemError.

• jon mentioned this in D8761: [identity] db method to get inbound keys for user.Aug 8 2023, 4:02 PM

bartek mentioned this in D8787: [services-lib] Make DB attribute names non-static.Aug 10 2023, 10:33 PM

bartek mentioned this in rCOMMff30037d57c5: [services-lib] Make DB attribute names non-static.Aug 16 2023, 2:25 PM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

32 lines

error.rs

2 lines

Diff 29628

View Options

services/identity/src/database.rs