[shared/grpc_clients] Export tonic to avoid version mismatch
ClosedPublic
Actions

Authored by • jon on Aug 22 2023, 10:43 AM.

Details

Reviewers

varun
bartek

Commits

rCOMMa97c8af031b2: [shared/grpc_clients] Export tonic to avoid version mismatch

Summary

If the consuming crate has a different version, then you will
get compilation errors when mismatching the different tonic versions.
Export tonic from grpc_clients to avoid this issues.

Also explicitly state that the build.rs should be re-ran if a proto
changes.

In support of https://linear.app/comm/issue/ENG-3977

Depends on D8891

Test Plan

Applied in next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 22 2023, 10:43 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 10:43 AM

Harbormaster completed remote builds in B22025: Diff 30238.Aug 22 2023, 11:00 AM

• jon requested review of this revision.Aug 22 2023, 11:00 AM

bartek accepted this revision.Aug 22 2023, 12:08 PM

This revision is now accepted and ready to land.Aug 22 2023, 12:08 PM

Fix docker build

Harbormaster completed remote builds in B22053: Diff 30273.Aug 23 2023, 1:08 PM

Rebase on top of master

Harbormaster completed remote builds in B22111: Diff 30345.Aug 25 2023, 5:18 PM

Closed by commit rCOMMa97c8af031b2: [shared/grpc_clients] Export tonic to avoid version mismatch (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMa97c8af031b2: [shared/grpc_clients] Export tonic to avoid version mismatch.

Revision Contents
Changeset List

Path

Size

shared/

grpc_clients/

build.rs

4 lines

src/

lib.rs

3 lines

Diff 30238

View Options

shared/grpc_clients/build.rs