Page MenuHomePhabricator
Differential D9014

[Commtest] Remove backup gRPC tests
AbandonedPublic
Actions

Authored by • jon on Aug 29 2023, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 4:38 PM
Unknown Object (File)
Tue, Nov 19, 4:38 PM
Unknown Object (File)
Tue, Nov 19, 4:35 PM
Unknown Object (File)
Oct 18 2024, 7:39 AM
Unknown Object (File)
Oct 18 2024, 7:39 AM
Unknown Object (File)
Oct 18 2024, 7:33 AM
Unknown Object (File)
Sep 27 2024, 2:40 PM
Unknown Object (File)
Sep 15 2024, 1:44 PM
View All 63 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
kamil
michal
Summary

Follow to https://phab.comm.dev/D8796. Since the tests in commtest
all interacted with the gRPC endpoints, decided to drop all tests related to
blob.

Test Plan
cd services/commtest
cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 29 2023, 1:41 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 29 2023, 1:41 PM
Harbormaster completed remote builds in B22235: Diff 30521.Aug 29 2023, 2:00 PM
• jon requested review of this revision.Aug 29 2023, 2:00 PM
• jon mentioned this in D9015: [shared/grpc_clients] Add verify_user_access_token().Aug 29 2023, 6:28 PM
bartek added a reviewer: michal.Aug 29 2023, 10:41 PM

I realized that this will conflict with D8966, depending on which one is landed first

michal accepted this revision.Aug 29 2023, 11:10 PM

I'm probably going to land the test improvements this morning, but accepting if it's blocking someone. I will rebase over this diff if required. If I land first we cancel this

This revision is now accepted and ready to land.Aug 29 2023, 11:10 PM
michal requested changes to this revision.Aug 30 2023, 1:28 AM

Landed D8966 so we can cancel this

This revision now requires changes to proceed.Aug 30 2023, 1:28 AM
• jon abandoned this revision.Aug 30 2023, 7:41 AM

https://phab.comm.dev/D8966 seems like the right approach. Closing

• jon mentioned this in rCOMM8a4af7fd5fb7: [shared/grpc_clients] Add verify_user_access_token().Aug 30 2023, 1:22 PM

Revision Contents
Changeset List

Diff 30521

View Options

services/commtest/src/backup/add_attachments.rs

Loading...
View Options

services/commtest/src/backup/backup_utils.rs

Loading...
View Options

services/commtest/src/backup/create_new_backup.rs

Loading...
View Options

services/commtest/src/backup/mod.rs

Loading...
View Options

services/commtest/src/backup/pull_backup.rs

Loading...
View Options

services/commtest/src/backup/send_log.rs

Loading...
View Options

services/commtest/src/lib.rs

Loading...
View Options

services/commtest/tests/backup_integration_test.rs

Loading...
View Options

services/commtest/tests/backup_performance_test.rs

Loading...