Page MenuHomePhabricator

[Commtest] Remove backup gRPC tests
AbandonedPublic

Authored by jon on Aug 29 2023, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 10:03 AM
Unknown Object (File)
Thu, Mar 6, 5:41 AM
Unknown Object (File)
Mar 1 2025, 3:24 PM
Unknown Object (File)
Mar 1 2025, 3:23 PM
Unknown Object (File)
Mar 1 2025, 3:01 PM
Unknown Object (File)
Feb 27 2025, 11:40 PM
Unknown Object (File)
Feb 19 2025, 1:06 PM
Unknown Object (File)
Feb 3 2025, 6:28 AM
Subscribers

Details

Summary

Follow to https://phab.comm.dev/D8796. Since the tests in commtest
all interacted with the gRPC endpoints, decided to drop all tests related to
blob.

Test Plan
cd services/commtest
cargo build

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

I realized that this will conflict with D8966, depending on which one is landed first

I'm probably going to land the test improvements this morning, but accepting if it's blocking someone. I will rebase over this diff if required. If I land first we cancel this

This revision is now accepted and ready to land.Aug 29 2023, 11:10 PM
michal requested changes to this revision.Aug 30 2023, 1:28 AM

Landed D8966 so we can cancel this

This revision now requires changes to proceed.Aug 30 2023, 1:28 AM

https://phab.comm.dev/D8966 seems like the right approach. Closing