Page MenuHomePhabricator

[lib] Add deviceTypes constant for enumerating all valid mobile device types
ClosedPublic

Authored by ashoat on Mar 7 2023, 7:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 2:08 AM
Unknown Object (File)
Mon, Apr 15, 2:08 AM
Unknown Object (File)
Mon, Apr 15, 2:08 AM
Unknown Object (File)
Mon, Apr 15, 2:06 AM
Unknown Object (File)
Feb 28 2024, 6:41 PM
Unknown Object (File)
Feb 28 2024, 6:40 PM
Unknown Object (File)
Feb 28 2024, 6:23 PM
Unknown Object (File)
Feb 28 2024, 5:43 PM
Subscribers

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Mar 7 2023, 7:48 AM
This revision is now accepted and ready to land.Mar 7 2023, 10:22 AM
This comment was removed by varun.

Not sure what you mean – deviceTypesObj can't be extended outside of this file since it's not exported. We're actually using Object.freeze for Flow, otherwise $Values<typeof deviceTypesObj> maps to string instead of 'ios' | 'android'

oh nvm, i’ll delete my comment