Differential D7768 Diff 26319 services/tunnelbroker/src/websockets/session.rs

Changeset View

Standalone View

				use tracing::debug;
				use tunnelbroker_messages::Messages;

				use crate::ACTIVE_CONNECTIONS;

				pub struct WebsocketSession {
				tx: tokio::sync::mpsc::UnboundedSender<std::string::String>,
				bartekUnsubmitted Done Inline Actions Nit: Is there a reason why you have a fully qualified name here? Can't we e.g. `use tokio::sync::mpsc;` and then call it `mpsc::UnboundedSender`? Also I think you can just use `String` bartek: Nit: Is there a reason why you have a fully qualified name here? Can't we e.g. `use tokio::sync…
				jonAuthorUnsubmitted Done Inline Actions Think I just copied the signature from an error output, but you're right. Should make this more human-readable. jon: Think I just copied the signature from an error output, but you're right. Should make this more…
				jonAuthorUnsubmitted Done Inline Actions Tackled this in D7800, when I polished a lot of this session code. jon: Tackled this in D7800, when I polished a lot of this session code.
				}

				impl WebsocketSession {
				pub fn new(
				tx: tokio::sync::mpsc::UnboundedSender<std::string::String>,
				) -> WebsocketSession {
				WebsocketSession { tx }
				}

				pub fn handle_message_from_device(
				&self,
				message: &str,
				) -> Result<(), serde_json::Error> {
				match serde_json::from_str::<Messages>(message)? {
				Messages::SessionRequest(session_info) => {
				ACTIVE_CONNECTIONS.insert(session_info.device_id, self.tx.clone());
				}
				_ => {
				debug!("Received invalid request");
				}
				}

				Ok(())
				}
				}