Differential D7800

[Tunnelbroker] Refactor connection lifetimes into session object
ClosedPublic
Actions

Authored by • jon on May 12 2023, 2:32 PM.

Tags

None

Referenced Files

	F1599452: D7800.diff
	Fri, Apr 19, 11:38 PM

	Unknown Object (File)
	Thu, Apr 18, 3:19 AM

	Unknown Object (File)
	Thu, Apr 18, 3:19 AM

	Unknown Object (File)
	Thu, Apr 18, 3:19 AM

	Unknown Object (File)
	Thu, Apr 18, 3:18 AM

	Unknown Object (File)
	Thu, Apr 18, 3:10 AM

	Unknown Object (File)
	Fri, Apr 12, 8:59 AM

	Unknown Object (File)
	Tue, Apr 9, 5:59 AM

View All 33 Files

Subscribers

Details

Reviewers

bartek
varun

Commits

rCOMMe9209308664f: [Tunnelbroker] Refactor connection lifetimes into session object

Summary

For better encapsulation around connection events
(e.g. device being authenticated and identified), moved
more of the connection logic into the session object.

Also, refine how connections are handled so they are properly
deregistered once a client closes a connection.

Depends on D7799

Test Plan

nix develop

# init localstack and run terraform
comm-dev services start
(cd services/terraform && ./run.sh)

(cd services/tunnelbroker && cargo run &)
(cd services/commtest && cargo test --test tunnelbroker_integration_test)
# Previously, running the suite twice would fail
(cd services/commtest && cargo test --test tunnelbroker_integration_test)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.May 12 2023, 2:32 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 12 2023, 2:32 PM

Harbormaster completed remote builds in B19308: Diff 26422.May 12 2023, 2:52 PM

• jon requested review of this revision.May 12 2023, 2:52 PM

• jon added a child revision: D7801: [Tunnelbroker] Remove usages of unwrap and expect.May 12 2023, 3:12 PM

• jon mentioned this in D7768: [Tunnelbroker] Encapsulate message handling with Session object.May 12 2023, 4:29 PM

• jon added inline comments.May 25 2023, 10:28 AM

services/tunnelbroker/src/websockets/session.rs
108 ↗	(On Diff #26422)	These unwraps get handled in the next diff. Just a lot of boilerplate to handle this nicely.

bartek accepted this revision.May 30 2023, 6:30 AM

This revision is now accepted and ready to land.May 30 2023, 6:30 AM

varun accepted this revision.May 30 2023, 2:08 PM

Rebase on previous changes

Harbormaster completed remote builds in B19945: Diff 27333.May 31 2023, 3:27 PM

Closed by commit rCOMMe9209308664f: [Tunnelbroker] Refactor connection lifetimes into session object (authored by • jon). · Explain WhyJun 1 2023, 7:15 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMe9209308664f: [Tunnelbroker] Refactor connection lifetimes into session object.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

tunnelbroker_integration_test.rs

14 lines

tunnelbroker/

1 line

src/

websockets/

69 lines

119 lines

Diff 27356

services/commtest/tests/tunnelbroker_integration_test.rs

Loading...

services/tunnelbroker/Cargo.lock

Loading...

services/tunnelbroker/Cargo.toml

Loading...

services/tunnelbroker/src/websockets/mod.rs

Loading...

services/tunnelbroker/src/websockets/session.rs

Loading...