Page MenuHomePhabricator

[Tunnelbroker] Create undelivered messages table
ClosedPublic

Authored by jon on May 4 2023, 9:52 AM.
Tags
None
Referenced Files
F571846: D7718.id27019.diff
Sun, Jun 4, 10:41 PM
Unknown Object (File)
Mon, May 22, 7:16 AM
Unknown Object (File)
Thu, May 18, 5:05 AM
Unknown Object (File)
Wed, May 17, 10:24 PM
Unknown Object (File)
Wed, May 17, 10:14 AM
Unknown Object (File)
Thu, May 11, 12:49 AM
Subscribers

Details

Summary

Create dynamoDB table for storing undelivered
messages

Part of: https://linear.app/comm/issue/ENG-3823

Test Plan
# start localstack
comm-dev services start

# ensure that tunnelbroker-undelivered-messages table is created
cd services/terraform
./run.sh

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2023, 10:07 AM
Harbormaster failed remote builds in B19048: Diff 26080!

Add createdAt as range_key

jon requested review of this revision.May 5 2023, 2:03 PM
services/terraform/dynamodb.tf
101–104 ↗(On Diff #26132)

In other places, we use the RFC3339 string as a timestamp. Not sure if it is a good candidate for a range key though

jon marked an inline comment as done.Tue, May 9, 11:17 PM
jon added inline comments.
services/terraform/dynamodb.tf
101–104 ↗(On Diff #26132)

I just intend to use this to order the messages, so seconds from EPOCH seems like a simple yet effective way to achieve this.

This also avoids having to parse the date back in.

bartek added inline comments.
services/terraform/dynamodb.tf
101–104 ↗(On Diff #26132)

That makes sense, thanks for explaining

This revision is now accepted and ready to land.Tue, May 9, 11:18 PM
jon marked 2 inline comments as done.Fri, May 12, 4:28 PM