Unwrap and expect were convenient for the happy cases. However,
they are unsatisfactory for actual edge cases as they cause panic which
puts tunnelbroker into a semi-broken state.
Depends on D7800
Details
Details
nix develop # init localstack and run terraform comm-dev services start (cd services/terraform && ./run.sh) (cd services/tunnelbroker && cargo run &) (cd services/commtest && cargo test --test tunnelbroker_integration_test)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Requesting changes only to get answer about using comm-services-lib
| services/tunnelbroker/src/database/message.rs | ||
|---|---|---|
| 16–19 ↗ | (On Diff #26424) | Maybe we could use types from comm-services-lib/database.rs? |
| 25–42 ↗ | (On Diff #26424) | Same as above, in comm-services-lib we have things as parse_string_attribute(), parse_number() etc... Perhaps they can be used here? |
| services/tunnelbroker/src/database/message.rs | ||
|---|---|---|
| 25–42 ↗ | (On Diff #26424) | I tried to use these utilities. But ran into some issues with imports. comm-services-lib still uses aws-sdk-dynamodb v0.24, while I'm currently using v0.27. They changed where AttributeValue is located. In v0.24, AttributeValue is in dynamodb::model, but in v0.27 it's dynamodb::types. Although reverting would be pretty easy for this diff. It would be a big change for much of my other code. I think the best path forward would be to update comm-services-lib, and then apply your suggestion. |
Comment Actions
Fair enough, accepting to unblock you now, but we definitely need to prioritize the comm-services-lib sync, or maintaining the lib will bring more costs than benefits. Anyway, this can be discussed in the Linear task you created ;)