Page MenuHomePhabricator

[Tunnelbroker] Create undelivered messages table
ClosedPublic

Authored by jon on May 4 2023, 9:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 1:45 PM
Unknown Object (File)
Sun, Feb 11, 4:40 AM
Unknown Object (File)
Sat, Feb 10, 8:23 AM
Unknown Object (File)
Sat, Feb 10, 8:22 AM
Unknown Object (File)
Sat, Feb 10, 8:22 AM
Unknown Object (File)
Sat, Feb 10, 8:20 AM
Unknown Object (File)
Sat, Feb 10, 8:12 AM
Unknown Object (File)
Sat, Feb 10, 7:56 AM
Subscribers

Details

Summary

Create dynamoDB table for storing undelivered
messages

Part of: https://linear.app/comm/issue/ENG-3823

Test Plan
# start localstack
comm-dev services start

# ensure that tunnelbroker-undelivered-messages table is created
cd services/terraform
./run.sh

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2023, 10:07 AM
Harbormaster failed remote builds in B19048: Diff 26080!

Add createdAt as range_key

services/terraform/dynamodb.tf
101–104

In other places, we use the RFC3339 string as a timestamp. Not sure if it is a good candidate for a range key though

jon added inline comments.
services/terraform/dynamodb.tf
101–104

I just intend to use this to order the messages, so seconds from EPOCH seems like a simple yet effective way to achieve this.

This also avoids having to parse the date back in.

bartek added inline comments.
services/terraform/dynamodb.tf
101–104

That makes sense, thanks for explaining

This revision is now accepted and ready to land.May 9 2023, 11:18 PM