Page MenuHomePhabricator

D13004.id43209.diff
No OneTemporary

D13004.id43209.diff

diff --git a/desktop/addons/windows-pushnotifications/binding.gyp b/desktop/addons/windows-pushnotifications/binding.gyp
--- a/desktop/addons/windows-pushnotifications/binding.gyp
+++ b/desktop/addons/windows-pushnotifications/binding.gyp
@@ -23,7 +23,7 @@
],
"msvs_settings": {
"VCCLCompilerTool": {
- "AdditionalOptions": ["/ZW"],
+ "AdditionalOptions": ["/std:c++17", "/ZW"],
"DisableSpecificWarnings": [4609],
"AdditionalUsingDirectories": [
"$(VC_ReferencesPath_VC_x86)/store/references",
@@ -33,4 +33,4 @@
},
}
}]
-}
\ No newline at end of file
+}
diff --git a/desktop/addons/windows-pushnotifications/package.json b/desktop/addons/windows-pushnotifications/package.json
--- a/desktop/addons/windows-pushnotifications/package.json
+++ b/desktop/addons/windows-pushnotifications/package.json
@@ -23,7 +23,7 @@
"preinstall": "bash ./preinstall.sh"
},
"dependencies": {
- "nan": "2.17.0"
+ "nan": "2.20.0"
},
"devDependencies": {
"node-gyp": "^9.3.1"
diff --git a/yarn.lock b/yarn.lock
--- a/yarn.lock
+++ b/yarn.lock
@@ -1540,7 +1540,7 @@
"@commapp/windowspush@file:desktop/addons/windows-pushnotifications":
version "0.0.1"
dependencies:
- nan "2.17.0"
+ nan "2.20.0"
"@discoveryjs/json-ext@^0.5.0":
version "0.5.7"
@@ -17850,7 +17850,12 @@
dependencies:
lru-cache "^4.1.3"
-nan@2.17.0, nan@^2.12.1, nan@^2.4.0:
+nan@2.20.0:
+ version "2.20.0"
+ resolved "https://registry.yarnpkg.com/nan/-/nan-2.20.0.tgz#08c5ea813dd54ed16e5bd6505bf42af4f7838ca3"
+ integrity sha512-bk3gXBZDGILuuo/6sKtr0DQmSThYHLtNCdSdXk9YkxD/jK6X2vmCyyXBBxyqZ4XcnzTyYEAThfX3DCEnLf6igw==
+
+nan@^2.12.1, nan@^2.4.0:
version "2.17.0"
resolved "https://registry.yarnpkg.com/nan/-/nan-2.17.0.tgz#c0150a2368a182f033e9aa5195ec76ea41a199cb"
integrity sha512-2ZTgtl0nJsO0KQCjEpxcIr5D+Yv90plTitZt9JBfQvVJDS5seMl3FOvsh3+9CoYWXf/1l5OaZzzF6nDm4cagaQ==

File Metadata

Mime Type
text/plain
Expires
Sat, Sep 21, 12:34 AM (20 h, 48 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2155182
Default Alt Text
D13004.id43209.diff (1 KB)

Event Timeline