We specify C++17 to override the default C++ edition for Visual Studio, C++20, which is not compatible with ZW. Additionally, the addon needs a newer version of the nan package to compile.
Details
Details
able to build the windows push notifications addon now
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
desktop/addons/windows-pushnotifications/binding.gyp | ||
---|---|---|
26 ↗ | (On Diff #43195) | Did we confirm this was necessary after we upgraded nan? Want to make sure it’s necessary… would rather have fewer config options if they’re not necessary |
Comment Actions
realized i forgot to add the lockfile. will update before landing
desktop/addons/windows-pushnotifications/binding.gyp | ||
---|---|---|
26 ↗ | (On Diff #43195) | we need both. the build fails with the "incompatibility between c++20 and ZW" error otherwise |
yarn.lock | ||
---|---|---|
17858 | Looks like these dependencies are for fsevents and macos-alias, which are still using the old nan:
Don't think either of those will be affected by the Windows issues we've seen, so we can leave it. But in the future, one thing we could do here would've been to update all of these to 2.20.0, since it looks like it just fixes bugs and shouldn't have negative effects |