HomePhabricator
Diffusion Comm 261ef8666355

remove nan@2.17.0 from yarn.lock

Description

remove nan@2.17.0 from yarn.lock

Summary:
in D13004, @ashoat wrote:

Looks like these dependencies are for fsevents and macos-alias, which are still using the old nan:
macos-alias is used by @electron-forge/maker-dmg, which is used in our electron-forge config
Version 1 of fsevents requires nan, but version 2 doesn't. We have dependencies on version 1 due to an old version of Jest that is required by hazel-server (we have the latest version of hazel-server)
Don't think either of those will be affected by the Windows issues we've seen, so we can leave it. But in the future, one thing we could do here would've been to update all of these to 2.20.0, since it looks like it just fixes bugs and shouldn't have negative effects

Test Plan: successfully built app on windows

Reviewers: ashoat

Reviewed By: ashoat

Subscribers: tomek, ashoat

Differential Revision: https://phab.comm.dev/D13012

Details

Provenance
varunAuthored on Aug 7 2024, 10:14 AM
Reviewer
ashoat
Differential Revision
D13012: remove nan@2.17.0 from yarn.lock
Parents
rCOMMfd73c26a8a93: [Tunnelbroker] Implement client method to get WNS token
Branches
Unknown
Tags
Unknown