HomePhabricator
Diffusion Comm 1e1c695ca3dc

[windows] override C++20 and upgrade nan package

Description

[windows] override C++20 and upgrade nan package

Summary: We specify C++17 to override the default C++ edition for Visual Studio, C++20, which is not compatible with ZW. Additionally, the addon needs a newer version of the nan package to compile.

Test Plan: able to build the windows push notifications addon now

Reviewers: ashoat, marcin

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13004

Details

Provenance
varunAuthored on Aug 6 2024, 6:13 PM
Reviewer
ashoat
Differential Revision
D13004: [windows] override C++20 and upgrade nan package
Parents
rCOMM130a1bc44270: [desktop] add cross-env dependency and use it to set environment variables in…
Branches
Unknown
Tags
Unknown