Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F2895199
D8735.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D8735.diff
View Options
diff --git a/keyserver/src/creators/account-creator.js b/keyserver/src/creators/account-creator.js
--- a/keyserver/src/creators/account-creator.js
+++ b/keyserver/src/creators/account-creator.js
@@ -46,6 +46,7 @@
} from '../fetchers/user-fetchers.js';
import { verifyCalendarQueryThreadIDs } from '../responders/entry-responders.js';
import { handleAsyncPromise } from '../responders/handlers.js';
+import { searchForUser } from '../search/users.js';
import { createNewUserCookie, setNewSession } from '../session/cookies.js';
import { createScriptViewer } from '../session/scripts.js';
import type { Viewer } from '../session/viewer.js';
@@ -74,12 +75,7 @@
throw new ServerError('invalid_username');
}
- const usernameQuery = SQL`
- SELECT COUNT(id) AS count
- FROM users
- WHERE LCASE(username) = LCASE(${request.username})
- `;
- const promises = [dbQuery(usernameQuery)];
+ const promises = [searchForUser(request.username)];
const {
calendarQuery,
signedIdentityKeysBlob,
@@ -89,14 +85,14 @@
promises.push(verifyCalendarQueryThreadIDs(calendarQuery));
}
- const [[usernameResult]] = await Promise.all(promises);
+ const [existingUser] = await Promise.all(promises);
if (
reservedUsernamesSet.has(request.username.toLowerCase()) ||
isValidEthereumAddress(request.username.toLowerCase())
) {
throw new ServerError('username_reserved');
}
- if (usernameResult[0].count !== 0) {
+ if (existingUser) {
throw new ServerError('username_taken');
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Oct 5, 5:24 PM (21 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2245117
Default Alt Text
D8735.diff (1 KB)
Attached To
Mode
D8735: [keyserver] dedup username db queries
Attached
Detach File
Event Timeline
Log In to Comment