[keyserver] dedup username db queries
ClosedPublic
Actions

Authored by varun on Aug 4 2023, 12:23 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMM4d3425cfeeaf: [keyserver] dedup username db queries

Summary

we have similar SQL queries in search/users.js and creators/account-creator.js. we should just use searchForUser everywhere

Test Plan

tried creating a user with a username that already exists. it failed, as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 4 2023, 12:23 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 4 2023, 12:23 PM

Harbormaster completed remote builds in B21545: Diff 29554.Aug 4 2023, 12:41 PM

varun requested review of this revision.Aug 4 2023, 12:41 PM

Talked to @varun offline. We have similar code in keyserver/src/search/users.js and keyserver/src/creators/account-creator.js... would be good to dedup all of it. searchForUser is probably good for what we need in all three cases

This revision now requires changes to proceed.Aug 4 2023, 12:47 PM

dedup search for username logic

need to update description and test plan

Harbormaster completed remote builds in B21963: Diff 30160.Aug 21 2023, 12:32 PM

varun retitled this revision from [keyserver] fetchUserIDForUsername helper function to [keyserver] dedup username db queries.Aug 22 2023, 12:31 PM

varun edited the summary of this revision. (Show Details)

varun edited the test plan for this revision. (Show Details)

varun requested review of this revision.Aug 22 2023, 12:46 PM

ashoat accepted this revision.Aug 22 2023, 9:16 PM

This revision is now accepted and ready to land.Aug 22 2023, 9:16 PM

Closed by commit rCOMM4d3425cfeeaf: [keyserver] dedup username db queries (authored by varun). · Explain WhyAug 23 2023, 8:41 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM4d3425cfeeaf: [keyserver] dedup username db queries.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

account-creator.js

12 lines

Diff 30263

View Options

keyserver/src/creators/account-creator.js

[keyserver] dedup username db queriesClosedPublicActions