Page MenuHomePhabricator
Files F3043150

D9072.id30712.diff
No OneTemporary
Actions

D9072.id30712.diff
View Options

diff --git a/native/chat/chat-thread-list-sidebar.react.js b/native/chat/chat-thread-list-sidebar.react.js
--- a/native/chat/chat-thread-list-sidebar.react.js
+++ b/native/chat/chat-thread-list-sidebar.react.js
@@ -32,21 +32,6 @@
extendArrow = false,
} = props;
- let arrow;
- if (extendArrow) {
- arrow = (
- <View style={styles.extendedArrow}>
- <ExtendedArrow />
- </View>
- );
- } else {
- arrow = (
- <View style={styles.arrow}>
- <Arrow />
- </View>
- );
- }
-
const { threadInfo } = sidebarInfo;
const onPress = React.useCallback(
@@ -54,18 +39,35 @@
[threadInfo, onPressItem],
);
- return (
- <Button
- iosFormat="highlight"
- iosHighlightUnderlayColor={colors.listIosHighlightUnderlay}
- iosActiveOpacity={0.85}
- style={styles.sidebar}
- onPress={onPress}
- >
- {arrow}
+ const arrow = React.useMemo(() => {
+ if (extendArrow) {
+ return (
+ <View style={styles.extendedArrow}>
+ <ExtendedArrow />
+ </View>
+ );
+ }
+ return (
+ <View style={styles.arrow}>
+ <Arrow />
+ </View>
+ );
+ }, [extendArrow, styles.arrow, styles.extendedArrow]);
+
+ const unreadIndicator = React.useMemo(
+ () => (
<View style={styles.unreadIndicatorContainer}>
<UnreadDot unread={sidebarInfo.threadInfo.currentUser.unread} />
</View>
+ ),
+ [
+ sidebarInfo.threadInfo.currentUser.unread,
+ styles.unreadIndicatorContainer,
+ ],
+ );
+
+ const swipeableThread = React.useMemo(
+ () => (
<View style={styles.swipeableThreadContainer}>
<SwipeableThread
threadInfo={sidebarInfo.threadInfo}
@@ -77,8 +79,40 @@
<SidebarItem sidebarInfo={sidebarInfo} />
</SwipeableThread>
</View>
- </Button>
+ ),
+ [
+ currentlyOpenedSwipeableId,
+ onSwipeableWillOpen,
+ sidebarInfo,
+ styles.swipeableThreadContainer,
+ ],
+ );
+
+ const chatThreadListSidebar = React.useMemo(
+ () => (
+ <Button
+ iosFormat="highlight"
+ iosHighlightUnderlayColor={colors.listIosHighlightUnderlay}
+ iosActiveOpacity={0.85}
+ style={styles.sidebar}
+ onPress={onPress}
+ >
+ {arrow}
+ {unreadIndicator}
+ {swipeableThread}
+ </Button>
+ ),
+ [
+ arrow,
+ colors.listIosHighlightUnderlay,
+ onPress,
+ styles.sidebar,
+ swipeableThread,
+ unreadIndicator,
+ ],
);
+
+ return chatThreadListSidebar;
}
const unboundStyles = {

File Metadata

Mime Type
text/plain
Expires
Wed, Oct 23, 2:17 PM (13 h, 2 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2346524
Default Alt Text
D9072.id30712.diff (2 KB)

Event Timeline