[native] Add some memoization to `ChatThreadListSidebar`
ClosedPublic
Actions

Authored by atul on Sep 1 2023, 3:58 PM.

Details

Reviewers

ginsu
rohan
tomek

Commits

rCOMM850ac7ef972c: [native] Add some memoization to `ChatThreadListSidebar`

Summary

Based on profiling flamegraph, it takes ~11ms to re-render ChatThreadListSidebar. If we have 4 ChatThreadListSidebars in the component tree re-rendering 5-6 times (as in "going to thread w/ varun scenario) that's ~220-264ms.

Depends on D9071

Test Plan

Before:

After:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 1 2023, 3:58 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 1 2023, 3:58 PM

atul edited the summary of this revision. (Show Details)Sep 1 2023, 3:58 PM

atul added a parent revision: D9071: [native] Add some memoization to `ColorSplotch`.

Harbormaster completed remote builds in B22357: Diff 30712.Sep 1 2023, 4:15 PM

atul requested review of this revision.Sep 1 2023, 4:15 PM

tomek accepted this revision.Sep 4 2023, 5:55 AM

This revision is now accepted and ready to land.Sep 4 2023, 5:55 AM

rebase and alnd

This revision was landed with ongoing or failed builds.Sep 6 2023, 1:33 PM

Closed by commit rCOMM850ac7ef972c: [native] Add some memoization to `ChatThreadListSidebar` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM850ac7ef972c: [native] Add some memoization to `ChatThreadListSidebar`.

Harbormaster completed remote builds in B22416: Diff 30813.Sep 6 2023, 1:51 PM

atul mentioned this in D9099: [native] Add memoization to `SidebarItem`.Sep 7 2023, 10:13 AM

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list-sidebar.react.js

84 lines

Diff 30815

View Options

native/chat/chat-thread-list-sidebar.react.js

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines	if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled();		await this.ensureAndroidPushNotifsEnabled();
}		}
}		}

async ensureAndroidPushNotifsEnabled() {		async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase();		const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission();		const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) {		if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions();		this.failedToRegisterPushPermissions();
return;		return;
}		}
}

const fcmToken = await firebase.messaging().getToken();		const fcmToken = await firebase.messaging().getToken();
if (fcmToken) {		if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken);		await this.handleAndroidDeviceToken(fcmToken);
} else {		} else {
this.failedToRegisterPushPermissions();		this.failedToRegisterPushPermissions();
}		}
}		}
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines

[native] Add some memoization to `ChatThreadListSidebar`ClosedPublicActions