User Details
- User Since
- Sep 13 2022, 9:12 AM (53 w, 4 d)
Yesterday
Pass in null parameter from non-problematic call sites
(notifRobotextForMessageInfo and getMessageTitle)
Sorry, could you actually rebase and use the renamed function getContentSigningKey (I just updated D9220)?
Rename getContentPublicKey -> getContentSigningKey and
contentPublicKey -> contentSigningKey
Thu, Sep 21
Consolidate retrieving device id logic into a helper function & use that in:
Use rawAESKey and aesKeyAsHexString
Wed, Sep 20
As discussed, landing as is and will address feedback / de-duping while working on the major changes
Tue, Sep 19
Mon, Sep 18
Fri, Sep 15
Nice to see the code a lot simpler!
If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?
Accepting since it seems reasonable to me, but not super familiar with why we introduced it here in the first place so letting others take a look
Thu, Sep 14
Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff
Wed, Sep 13
Rebase
Attempt rebase
Mon, Sep 11
Changes look good, thanks for fixing this!
Rebase stack
Use React.useCallback
Rebase
Fri, Sep 8
Rename all instances of '...Url' with '...URL'
Use getContentSigningKey
Thu, Sep 7
Attempt to fix COCOAPODS upgrade
Wed, Sep 6
Tue, Sep 5
Not sure if we actually need to add the dependency, planning changes to confirm before requesting review
Fri, Sep 1
I spent some time walking through the logic and it makes sense to me. Extracting out messageThread.community, mentionedThread.community and genesis.id to variables and using those instead of accessing the object each time would read better to me, but that may just be personal preference
Thanks for doing this!! Tests look great. I think outside of this file the pattern is to typically use it('should...), but I don't think it's a big deal
Didn't review this super closely, seems like just a move
Thu, Aug 31
Address CI failures
Cool find, wouldn't have expected this!
Re-requesting review after addressing feedback
Address feedback
Going to handle this in D9028