Page MenuHomePhabricator

rohan (Rohan Khanderia)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2022, 9:12 AM (53 w, 4 d)

Recent Activity

Yesterday

rohan updated the diff for D9249: [lib] Extend RobotextParams to include parentThreadInfo.

Pass in null parameter from non-problematic call sites
(notifRobotextForMessageInfo and getMessageTitle)

Fri, Sep 22, 1:35 PM
rohan added inline comments to D9249: [lib] Extend RobotextParams to include parentThreadInfo.
Fri, Sep 22, 1:34 PM
rohan closed D9220: [keyserver] Encode the device id into the QR code.
Fri, Sep 22, 8:15 AM
rohan committed rCOMMefc194158d4f: [keyserver] Encode the device id into the QR code (authored by rohan).
[keyserver] Encode the device id into the QR code
Fri, Sep 22, 8:15 AM
rohan closed D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.
Fri, Sep 22, 7:40 AM
rohan committed rCOMM9a08fd6f2883: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex… (authored by rohan).
[keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex…
Fri, Sep 22, 7:40 AM
rohan closed D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.
Fri, Sep 22, 7:40 AM
rohan committed rCOMM1470feaff259: [keyserver] Generate an AES256 key (ephemeral) to encode (authored by rohan).
[keyserver] Generate an AES256 key (ephemeral) to encode
Fri, Sep 22, 7:40 AM
rohan added a comment to D9264: [keyserver] use correct key for device ID.

Sorry, could you actually rebase and use the renamed function getContentSigningKey (I just updated D9220)?

Fri, Sep 22, 7:35 AM
rohan updated the diff for D9220: [keyserver] Encode the device id into the QR code.

Rename getContentPublicKey -> getContentSigningKey and
contentPublicKey -> contentSigningKey

Fri, Sep 22, 7:34 AM
rohan accepted D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 7:31 AM

Thu, Sep 21

rohan closed D9180: [keyserver] Print out a QR code to the terminal.
Thu, Sep 21, 10:21 AM
rohan committed rCOMM5842359feb58: [keyserver] Print out a QR code to the terminal (authored by rohan).
[keyserver] Print out a QR code to the terminal
Thu, Sep 21, 10:21 AM
rohan added inline comments to D9249: [lib] Extend RobotextParams to include parentThreadInfo.
Thu, Sep 21, 8:54 AM
rohan accepted D9251: [keyserver] Remove unused exports in message-fetchers.js.
Thu, Sep 21, 8:40 AM
rohan added inline comments to D9220: [keyserver] Encode the device id into the QR code.
Thu, Sep 21, 8:31 AM
rohan updated the diff for D9220: [keyserver] Encode the device id into the QR code.

Consolidate retrieving device id logic into a helper function & use that in:

Thu, Sep 21, 8:29 AM
rohan updated the diff for D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.

Use rawAESKey and aesKeyAsHexString

Thu, Sep 21, 6:30 AM

Wed, Sep 20

rohan requested review of D9249: [lib] Extend RobotextParams to include parentThreadInfo.
Wed, Sep 20, 11:25 AM
rohan closed D9238: [lib] Extract the unsupported sidebar source message types to one single source of truth.
Wed, Sep 20, 9:21 AM
rohan closed D9239: [keyserver] Prevent non-composable message types from being pinned on the keyserver.
Wed, Sep 20, 9:21 AM
rohan closed D9237: [lib] Update useCanCreateSidebarFromMessage to prevent sidebar creation for unsupported message types.
Wed, Sep 20, 9:21 AM
rohan committed rCOMM9e8f0491295e: [lib] Extract the unsupported sidebar source message types to one single source… (authored by rohan).
[lib] Extract the unsupported sidebar source message types to one single source…
Wed, Sep 20, 9:21 AM
rohan committed rCOMMbca46dc9ac6c: [lib] Update useCanCreateSidebarFromMessage to prevent sidebar creation for… (authored by rohan).
[lib] Update useCanCreateSidebarFromMessage to prevent sidebar creation for…
Wed, Sep 20, 9:21 AM
rohan committed rCOMM2954159c828e: [keyserver] Prevent non-composable message types from being pinned on the… (authored by rohan).
[keyserver] Prevent non-composable message types from being pinned on the…
Wed, Sep 20, 9:21 AM
rohan added a comment to D9238: [lib] Extract the unsupported sidebar source message types to one single source of truth.

As discussed, landing as is and will address feedback / de-duping while working on the major changes

Wed, Sep 20, 9:17 AM

Tue, Sep 19

rohan requested review of D9239: [keyserver] Prevent non-composable message types from being pinned on the keyserver.
Tue, Sep 19, 11:21 PM
rohan requested review of D9238: [lib] Extract the unsupported sidebar source message types to one single source of truth.
Tue, Sep 19, 11:18 PM
rohan requested review of D9237: [lib] Update useCanCreateSidebarFromMessage to prevent sidebar creation for unsupported message types.
Tue, Sep 19, 11:17 PM
rohan accepted D9234: [keyserver] Skip early exit in deleteThread if ignorePermissions.
Tue, Sep 19, 9:15 PM
rohan accepted D9203: [web] introduce AppearanceChangeModal.
Tue, Sep 19, 9:47 AM

Mon, Sep 18

rohan closed D9221: [web] Fix capitalization of roles modal.
Mon, Sep 18, 2:54 PM
rohan committed rCOMM19efb9a5fb8e: [web] Fix capitalization of roles modal (authored by rohan).
[web] Fix capitalization of roles modal
Mon, Sep 18, 2:54 PM
rohan requested review of D9221: [web] Fix capitalization of roles modal.
Mon, Sep 18, 12:57 PM
rohan requested review of D9220: [keyserver] Encode the device id into the QR code.
Mon, Sep 18, 10:19 AM
rohan closed D9089: [keyserver] Add the qrcode dependency for terminal output.
Mon, Sep 18, 10:15 AM
rohan committed rCOMM5cd376aa8df6: [keyserver] Add the qrcode dependency for terminal output (authored by rohan).
[keyserver] Add the qrcode dependency for terminal output
Mon, Sep 18, 10:15 AM

Fri, Sep 15

rohan accepted D9212: [native] Consume `useThreadListSearch` in `ChatThreadList`.

Nice to see the code a lot simpler!

Fri, Sep 15, 2:28 PM
rohan accepted D9214: [native] Memoize `ConnectedRemoteImage`.

If the performance isn't impacted much one way or the other, is the memory usage of memoizing this not noticeable as well?

Fri, Sep 15, 2:21 PM
rohan accepted D9213: [native] Memoize `ThreadAncestorsLabel`.
Fri, Sep 15, 2:13 PM
rohan resigned from D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
Fri, Sep 15, 2:12 PM
rohan accepted D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.

Accepting since it seems reasonable to me, but not super familiar with why we introduced it here in the first place so letting others take a look

Fri, Sep 15, 2:12 PM

Thu, Sep 14

rohan added a comment to D9194: [web] introduce useStaffCanSee hook for web.
In D9194#270776, @ginsu wrote:

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

I thought about that but native has it's own version of the useStaffCanSee hook that is slightly different. The native version of useStaffCanSee also considers if the user is using a staff release as well that web does not need to consider. I thought it would make more sense/be less confusing for other devs that use this in the future if the different versions of each hook lived in their own respective platform folders, but if others disagree happy to make the necessary changes

Thu, Sep 14, 8:25 AM
rohan requested review of D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.
Thu, Sep 14, 8:16 AM
rohan accepted D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.
Thu, Sep 14, 7:43 AM
rohan accepted D9195: [web] introduce preferences settings in account settings.
Thu, Sep 14, 7:40 AM
rohan accepted D9194: [web] introduce useStaffCanSee hook for web.

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

Thu, Sep 14, 7:40 AM

Wed, Sep 13

rohan added a comment to D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.

Can we use any random string as an AES-256 key? Or are there some additional requirements?

Wed, Sep 13, 9:53 AM
rohan requested review of D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.
Wed, Sep 13, 9:21 AM
rohan requested review of D9180: [keyserver] Print out a QR code to the terminal.
Wed, Sep 13, 9:17 AM
rohan accepted D9126: [web][native] Fix message search showing toggle pin robotext.
Wed, Sep 13, 8:48 AM
rohan closed D9096: [web/native] Retrieve and encode the ed25519 key in the QR code.
Wed, Sep 13, 8:41 AM
rohan committed rCOMM9f9c3669c4cc: [web/native] Retrieve and encode the ed25519 key in the QR code (authored by rohan).
[web/native] Retrieve and encode the ed25519 key in the QR code
Wed, Sep 13, 8:41 AM
rohan closed D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Wed, Sep 13, 8:41 AM
rohan committed rCOMM1c46e6188680: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code (authored by rohan).
[lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code
Wed, Sep 13, 8:41 AM
rohan updated the diff for D9096: [web/native] Retrieve and encode the ed25519 key in the QR code.

Rebase

Wed, Sep 13, 8:38 AM
rohan updated the diff for D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.

Attempt rebase

Wed, Sep 13, 8:36 AM

Mon, Sep 11

rohan closed D9112: [lib/native] Remain consistent with url naming pattern.
Mon, Sep 11, 12:49 PM
rohan committed rCOMM67bdf1ce42ff: [lib/native] Remain consistent with url naming pattern (authored by rohan).
[lib/native] Remain consistent with url naming pattern
Mon, Sep 11, 12:49 PM
rohan accepted D9126: [web][native] Fix message search showing toggle pin robotext.

Changes look good, thanks for fixing this!

Mon, Sep 11, 7:01 AM
rohan updated the diff for D9096: [web/native] Retrieve and encode the ed25519 key in the QR code.

Rebase stack

Mon, Sep 11, 6:48 AM
rohan updated the diff for D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.

Use React.useCallback

Mon, Sep 11, 6:48 AM
rohan added inline comments to D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Mon, Sep 11, 6:41 AM
rohan updated the diff for D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.

Rebase

Mon, Sep 11, 6:41 AM

Fri, Sep 8

rohan updated the diff for D9112: [lib/native] Remain consistent with url naming pattern.

Rename all instances of '...Url' with '...URL'

Fri, Sep 8, 9:56 AM
rohan requested review of D9112: [lib/native] Remain consistent with url naming pattern.
Fri, Sep 8, 8:10 AM
rohan added inline comments to D8934: [keyserver/lib/web/native] Support external cameras scanning the QR code.
Fri, Sep 8, 7:53 AM
rohan updated the diff for D9096: [web/native] Retrieve and encode the ed25519 key in the QR code.

Use getContentSigningKey

Fri, Sep 8, 7:38 AM
rohan added inline comments to D9096: [web/native] Retrieve and encode the ed25519 key in the QR code.
Fri, Sep 8, 7:34 AM

Thu, Sep 7

rohan requested review of D9096: [web/native] Retrieve and encode the ed25519 key in the QR code.
Thu, Sep 7, 7:37 AM
rohan updated the diff for D9089: [keyserver] Add the qrcode dependency for terminal output.

Attempt to fix COCOAPODS upgrade

Thu, Sep 7, 7:35 AM
rohan added inline comments to D9089: [keyserver] Add the qrcode dependency for terminal output.
Thu, Sep 7, 7:34 AM
rohan updated the summary of D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Thu, Sep 7, 7:19 AM
rohan updated the summary of D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Thu, Sep 7, 7:19 AM
rohan requested review of D9089: [keyserver] Add the qrcode dependency for terminal output.
Thu, Sep 7, 7:04 AM

Wed, Sep 6

rohan requested review of D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Wed, Sep 6, 9:10 AM

Tue, Sep 5

rohan planned changes to D9089: [keyserver] Add the qrcode dependency for terminal output.

Not sure if we actually need to add the dependency, planning changes to confirm before requesting review

Tue, Sep 5, 10:55 AM
rohan requested review of D9089: [keyserver] Add the qrcode dependency for terminal output.
Tue, Sep 5, 10:55 AM

Fri, Sep 1

rohan added inline comments to D9006: [keyserver] Introduce function which checks if thread is mentionable.
Fri, Sep 1, 8:49 AM
rohan accepted D9006: [keyserver] Introduce function which checks if thread is mentionable.

I spent some time walking through the logic and it makes sense to me. Extracting out messageThread.community, mentionedThread.community and genesis.id to variables and using those instead of accessing the object each time would read better to me, but that may just be personal preference

Fri, Sep 1, 7:40 AM
rohan accepted D9056: [lib] Add unit tests for chat mention regex.

Thanks for doing this!! Tests look great. I think outside of this file the pattern is to typically use it('should...), but I don't think it's a big deal

Fri, Sep 1, 7:24 AM
rohan accepted D9061: [lib][native][web] Move validChatNameRegex to validation-utils.js.

Didn't review this super closely, seems like just a move

Fri, Sep 1, 7:20 AM
rohan closed D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.
Fri, Sep 1, 7:17 AM
rohan committed rCOMM02c05d9f0771: [native] Refactor the deep links context provider to support both invite links… (authored by rohan).
[native] Refactor the deep links context provider to support both invite links…
Fri, Sep 1, 7:17 AM

Thu, Aug 31

rohan closed D9027: [native] Rename InviteLinksContext and InviteLinksContextProvider to DeepLinksContext and DeepLinksContextProvider.
Thu, Aug 31, 10:17 AM
rohan committed rCOMM016023f848b7: [native] Rename InviteLinksContext and InviteLinksContextProvider to… (authored by rohan).
[native] Rename InviteLinksContext and InviteLinksContextProvider to…
Thu, Aug 31, 10:17 AM
rohan closed D9026: [lib/native] Extract link parsing utils to lib.
Thu, Aug 31, 10:17 AM
rohan committed rCOMM1aa986e2d476: [lib/native] Extract link parsing utils to lib (authored by rohan).
[lib/native] Extract link parsing utils to lib
Thu, Aug 31, 10:17 AM
rohan added inline comments to D9050: [native] Add some memoization to `Timestamp` component.
Thu, Aug 31, 9:56 AM
rohan updated the diff for D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.

Address CI failures

Thu, Aug 31, 9:04 AM
rohan accepted D9050: [native] Add some memoization to `Timestamp` component.

Cool find, wouldn't have expected this!

Thu, Aug 31, 8:52 AM
rohan planned changes to D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.
Thu, Aug 31, 8:38 AM
rohan requested review of D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.

Re-requesting review after addressing feedback

Thu, Aug 31, 8:22 AM
rohan updated the diff for D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.

Address feedback

Thu, Aug 31, 8:22 AM
rohan abandoned D9029: [native] Remove QRCodeLinkHandler from the codebase.

Going to handle this in D9028

Thu, Aug 31, 7:48 AM
rohan added a comment to D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.
In D9028#266436, @tomek wrote:

Shouldn't we delete QRCodeLinkHandler as a part of this diff?

Thu, Aug 31, 7:47 AM

Wed, Aug 30

rohan accepted D8943: [web] Refactor TypeaheadTooltip component.
Wed, Aug 30, 10:23 AM
rohan added a comment to D9006: [keyserver] Introduce function which checks if thread is mentionable.

maybe it'd be good to have a blocking reviewer who is more familiar [with recursive SQL queries]

This query was taken from here (just changed containing_thread_id to parent_thread_id). It was actually written by me (with Ashoats help) so logically I should be a blocking reviewer since this code is the only recursive query in the keyserver :D. But I will find someone who knows more about recursive queries and add them as a blocking reviewer.

Wed, Aug 30, 9:15 AM
rohan requested review of D9028: [native] Refactor the deep links context provider to support both invite links and QR code links.
Wed, Aug 30, 9:06 AM
rohan requested review of D9029: [native] Remove QRCodeLinkHandler from the codebase.
Wed, Aug 30, 9:06 AM