Page MenuHomePhabricator

rohan (Rohan Khanderia)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2022, 9:12 AM (27 w, 7 h)

Recent Activity

Today

rohan added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.
In D6924#211499, @tomek wrote:

How the pinning will be saved on client's side? Do we plan to have it included in a message info? If that's the case, do we plan to update all the message infos saved on all the clients?

Tue, Mar 21, 12:06 PM
rohan updated the diff for D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.

Call parseMessageSQLResult instead of rawMessageInfoFromRows

Tue, Mar 21, 8:41 AM
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Tue, Mar 21, 7:44 AM
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Tue, Mar 21, 7:39 AM

Yesterday

rohan requested review of D7112: [keyserver/lib] Set up responders, endpoints, and related functions to fetch all pinned messages.
Mon, Mar 20, 7:18 PM
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Mon, Mar 20, 6:26 PM
rohan updated the diff for D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.

Rename types

Mon, Mar 20, 6:25 PM
rohan requested review of D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Mon, Mar 20, 3:54 PM
rohan updated the diff for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.

Update toggleMessagePinRequestInputValidator

Mon, Mar 20, 1:25 PM
rohan attached a referenced file: F436013: Screenshot 2023-03-20 at 4.09.42 PM.png.
Mon, Mar 20, 1:21 PM
rohan attached a referenced file: F436014: Screenshot 2023-03-20 at 4.09.56 PM.png.
Mon, Mar 20, 1:21 PM
rohan updated the test plan for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Mon, Mar 20, 1:21 PM
rohan updated the diff for D6929: [keyserver] Add a function to toggle the pin status of a message.

Update ToggleMessagePinRequest

Mon, Mar 20, 1:19 PM
rohan updated the summary of D6924: [keyserver] Introduce columns in messages table to support pinned messages.
Mon, Mar 20, 12:41 PM
rohan added inline comments to D6929: [keyserver] Add a function to toggle the pin status of a message.
Mon, Mar 20, 12:40 PM
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 12:01 PM
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 12:01 PM
rohan attached a referenced file: F435800: memberships.png.
Mon, Mar 20, 12:00 PM
rohan attached a referenced file: F435799: roles.png.
Mon, Mar 20, 12:00 PM
rohan attached a referenced file: F435798: migration.png.
Mon, Mar 20, 12:00 PM
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 12:00 PM
rohan updated the diff for D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.

Simplify the migration

Mon, Mar 20, 11:59 AM
rohan attached a referenced file: F435771: Screenshot 2023-03-20 at 2.58.02 PM.png.
Mon, Mar 20, 11:58 AM
rohan retitled D6924: [keyserver] Introduce columns in messages table to support pinned messages from [keyserver] Introduce a pinned_messages table to [keyserver] Introduce columns in messages table to support pinned messages.
Mon, Mar 20, 11:58 AM
rohan updated the diff for D6924: [keyserver] Introduce columns in messages table to support pinned messages.

Introduce two columns in messages

Mon, Mar 20, 11:56 AM

Tue, Mar 7

rohan added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.
In D6924#207293, @tomek wrote:

On the other hand creating a new table also has some issues from the design's perspective. For example, thread column is a function of messageID because based on message id we can uniquely identify a thread. So this new table isn't e.g. a joining table but instead it depends on just messages table and could be replaced by new columns (is_pinned and pin_timestamp) on it.

I'm not sure, at this point, what is the best design here, but I think that we should spent a little more time figuring it out.

Tue, Mar 7, 5:19 AM

Fri, Mar 3

rohan closed D6865: [web] Allow media gallery items to click through to a full screen view on web.
Fri, Mar 3, 4:34 AM
rohan committed rCOMM82162de510a5: [web] Allow media gallery items to click through to a full screen view on web (authored by rohan).
[web] Allow media gallery items to click through to a full screen view on web
Fri, Mar 3, 4:34 AM

Thu, Mar 2

rohan updated the test plan for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Thu, Mar 2, 4:32 PM
rohan requested review of D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Thu, Mar 2, 1:18 PM
rohan updated the diff for D6929: [keyserver] Add a function to toggle the pin status of a message.

Flip the isPinned condition

Thu, Mar 2, 1:05 PM
rohan requested review of D6929: [keyserver] Add a function to toggle the pin status of a message.
Thu, Mar 2, 1:02 PM
rohan added inline comments to D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Thu, Mar 2, 11:24 AM
rohan requested review of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Thu, Mar 2, 11:17 AM
rohan planned changes to D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.

I'm going to wait until the architecture of pinned_messages is decided in D6924 before requesting review, I just put this up so I could continue working locally.

Thu, Mar 2, 10:32 AM
rohan requested review of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Thu, Mar 2, 10:31 AM
rohan updated the summary of D6924: [keyserver] Introduce columns in messages table to support pinned messages.
Thu, Mar 2, 8:23 AM

Wed, Mar 1

rohan added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.
In D6924#206038, @atul wrote:

While I agree that it might be better database design to create a separate table, it will complicate things on the SQLite side.

We persist messageStore.messages and threadStore in SQLite on the native client, and it would probably make the most sense to store pinned_messages in the SQLite threads table instead of introducing a whole new table and set of “ops.” That would introduce inconsistency between the MariaDB and SQLite database… which isn’t the end of the world, but could be avoided if we stored pinned_messages in the threads table?

Wed, Mar 1, 10:35 AM
rohan abandoned D5865: [native] Break spoiler text into individual components for rendering.

Abandoning this since this isn't actively being worked on, but it can be revisited and reopened at a later point if needed

Wed, Mar 1, 7:59 AM
rohan requested review of D6924: [keyserver] Introduce columns in messages table to support pinned messages.
Wed, Mar 1, 7:43 AM

Tue, Feb 28

rohan added a comment to D6865: [web] Allow media gallery items to click through to a full screen view on web.

Hey @rohan, you seem to have partially landed your stack. Just wanted to get some clarification – what is the current state of master after your partial land? I want to make sure we aren't in a bad state where we are blocked from deploys. (If so, we should revert)

Tue, Feb 28, 2:12 PM
rohan updated the summary of D6865: [web] Allow media gallery items to click through to a full screen view on web.
Tue, Feb 28, 2:07 PM
rohan closed D6864: [web] Link modal in the thread menu.
Tue, Feb 28, 2:05 PM
rohan committed rCOMM641bc70c6e8a: [web] Link modal in the thread menu (authored by rohan).
[web] Link modal in the thread menu
Tue, Feb 28, 2:05 PM
rohan closed D6863: [web] Create a new modal for the media gallery on web.
Tue, Feb 28, 2:05 PM
rohan committed rCOMM5596e52e5334: [web] Create a new modal for the media gallery on web (authored by rohan).
[web] Create a new modal for the media gallery on web
Tue, Feb 28, 2:05 PM

Mon, Feb 27

rohan updated the summary of D6865: [web] Allow media gallery items to click through to a full screen view on web.
Mon, Feb 27, 3:52 PM
rohan updated the summary of D6865: [web] Allow media gallery items to click through to a full screen view on web.
Mon, Feb 27, 3:52 PM
rohan updated the summary of D6865: [web] Allow media gallery items to click through to a full screen view on web.
Mon, Feb 27, 3:51 PM

Sun, Feb 26

rohan attached a referenced file: F402973: Screen Recording 2023-02-26 at 9.44.39 PM.mov.
Sun, Feb 26, 6:46 PM
rohan updated the test plan for D6865: [web] Allow media gallery items to click through to a full screen view on web.
Sun, Feb 26, 6:46 PM
rohan updated the diff for D6865: [web] Allow media gallery items to click through to a full screen view on web.

Revert Modal changes

Sun, Feb 26, 4:20 PM
rohan added 1 blocking reviewer(s) for D6865: [web] Allow media gallery items to click through to a full screen view on web: atul.
Sun, Feb 26, 4:16 PM
rohan updated the diff for D6865: [web] Allow media gallery items to click through to a full screen view on web.

Use MultimediaModal and allow video support for the modal

Sun, Feb 26, 4:16 PM
rohan closed D6720: [native] Create the full screen media gallery component.
Sun, Feb 26, 11:52 AM
rohan committed rCOMM188e6df1ad83: [native] Create the full screen media gallery component (authored by rohan).
[native] Create the full screen media gallery component
Sun, Feb 26, 11:52 AM
rohan closed D6718: [native] Navigate to the image / video modal when a user clicks on a media item.
Sun, Feb 26, 11:51 AM
rohan committed rCOMM6f6e14289405: [native] Navigate to the image / video modal when a user clicks on a media item (authored by rohan).
[native] Navigate to the image / video modal when a user clicks on a media item
Sun, Feb 26, 11:51 AM
rohan closed D6660: [native] Allow user to ‘see more’ on native and navigate to a full screen gallery.
Sun, Feb 26, 11:51 AM
rohan committed rCOMMa36d44a21dbe: [native] Allow user to ‘see more’ on native and navigate to a full screen… (authored by rohan).
[native] Allow user to ‘see more’ on native and navigate to a full screen…
Sun, Feb 26, 11:51 AM
rohan closed D6659: [native] Display both photos and videos in the media gallery on native.
Sun, Feb 26, 11:49 AM
rohan committed rCOMMea3f91b287d3: [native] Display both photos and videos in the media gallery on native (authored by rohan).
[native] Display both photos and videos in the media gallery on native
Sun, Feb 26, 11:49 AM
rohan closed D6587: [keyserver] Use the internal-ip package in the dev environment to ensure physical device / emulators can access uploads.
Sun, Feb 26, 11:49 AM
rohan committed rCOMMc5e3e7ca5bc8: [keyserver] Use the internal-ip package in the dev environment to ensure… (authored by rohan).
[keyserver] Use the internal-ip package in the dev environment to ensure…
Sun, Feb 26, 11:49 AM
rohan closed D6531: [keyserver/lib] Set up the endpoints and responder for retrieving media.
Sun, Feb 26, 11:48 AM
rohan committed rCOMMb813c7baa64b: [keyserver/lib] Set up the endpoints and responder for retrieving media (authored by rohan).
[keyserver/lib] Set up the endpoints and responder for retrieving media
Sun, Feb 26, 11:48 AM
rohan closed D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Sun, Feb 26, 11:47 AM
rohan committed rCOMM9d78e018f716: [keyserver] Create a function to query for all uploads from a provided threadID (authored by rohan).
[keyserver] Create a function to query for all uploads from a provided threadID
Sun, Feb 26, 11:47 AM
rohan closed D6482: [keyserver] Attach a threadID to each media (image/video) upload.
Sun, Feb 26, 11:46 AM
rohan committed rCOMMbe43778193f8: [keyserver] Attach a threadID to each media (image/video) upload (authored by rohan).
[keyserver] Attach a threadID to each media (image/video) upload
Sun, Feb 26, 11:46 AM
rohan closed D6467: [native] Render the media gallery in the thread settings on native.
Sun, Feb 26, 11:46 AM
rohan committed rCOMM6e2f92634d55: [native] Render the media gallery in the thread settings on native (authored by rohan).
[native] Render the media gallery in the thread settings on native
Sun, Feb 26, 11:46 AM
rohan closed D6466: [native] Create a component for the media gallery on native.
Sun, Feb 26, 11:45 AM
rohan committed rCOMMdf01c28141f8: [native] Create a component for the media gallery on native (authored by rohan).
[native] Create a component for the media gallery on native
Sun, Feb 26, 11:45 AM
rohan closed D6465: [keyserver] Add thread column to uploads table.
Sun, Feb 26, 11:41 AM
rohan committed rCOMMb9978e316b41: [keyserver] Add thread column to uploads table (authored by rohan).
[keyserver] Add thread column to uploads table
Sun, Feb 26, 11:41 AM
rohan updated the diff for D6482: [keyserver] Attach a threadID to each media (image/video) upload.

Rebase

Sun, Feb 26, 11:31 AM
rohan updated the diff for D6467: [native] Render the media gallery in the thread settings on native.

Rebase

Sun, Feb 26, 11:31 AM
rohan updated the diff for D6466: [native] Create a component for the media gallery on native.

Rebase

Sun, Feb 26, 11:30 AM
rohan updated the diff for D6465: [keyserver] Add thread column to uploads table.

Rebase

Sun, Feb 26, 11:30 AM
rohan removed 1 blocking reviewer(s) for D6864: [web] Link modal in the thread menu: atul.
Sun, Feb 26, 7:52 AM
rohan updated the summary of D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Sun, Feb 26, 7:51 AM
rohan added a comment to D6865: [web] Allow media gallery items to click through to a full screen view on web.

Why are we using Modal though? Should we just update MultimediaModal to look like those designs?

Sun, Feb 26, 7:41 AM
rohan added a comment to D6485: [keyserver] Create a function to query for all uploads from a provided threadID.

On the ORDER BY / LIMIT question from earlier, I think you had mentioned over chat that you would have to wrap the SELECT / UNION SELECT and apply them to the whole thing. Is that still your belief? I noticed this StackOverflow implies the opposite, but I haven't done any testing to confirm.

Sun, Feb 26, 7:32 AM
rohan updated the diff for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.

Make sure lines are < 80 characters

Sun, Feb 26, 7:20 AM
rohan attached a referenced file: F402533: Screenshot 2023-02-26 at 10.16.43 AM.png.
Sun, Feb 26, 7:17 AM
rohan updated the test plan for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Sun, Feb 26, 7:17 AM

Sat, Feb 25

rohan requested review of D6485: [keyserver] Create a function to query for all uploads from a provided threadID.
Sat, Feb 25, 12:55 PM
rohan updated the diff for D6531: [keyserver/lib] Set up the endpoints and responder for retrieving media.

Pass in viewer parameter

Sat, Feb 25, 12:54 PM
rohan updated the diff for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.

Check visible permission

Sat, Feb 25, 12:54 PM
rohan added 1 blocking reviewer(s) for D6864: [web] Link modal in the thread menu: atul.
Sat, Feb 25, 6:06 AM

Fri, Feb 24

rohan attached a referenced file: F401047: Screenshot 2023-02-24 at 5.23.21 PM.png.
Fri, Feb 24, 2:27 PM
rohan updated the diff for D6485: [keyserver] Create a function to query for all uploads from a provided threadID.

thumbnailUploadType and thumbnailUploadExtra are not used so I'm removing them from the query

Fri, Feb 24, 2:26 PM
rohan updated the diff for D6863: [web] Create a new modal for the media gallery on web.

Address feedback on filteredMediaInfos

Fri, Feb 24, 1:55 PM
rohan updated the diff for D6863: [web] Create a new modal for the media gallery on web.

Rebase on D6485

Fri, Feb 24, 1:53 PM
rohan updated the diff for D6720: [native] Create the full screen media gallery component.

Rebase on D6485

Fri, Feb 24, 1:50 PM
rohan updated the diff for D6718: [native] Navigate to the image / video modal when a user clicks on a media item.

Rebase on D6485

Fri, Feb 24, 1:50 PM
rohan updated the diff for D6660: [native] Allow user to ‘see more’ on native and navigate to a full screen gallery.

Rebase on D6485

Fri, Feb 24, 1:50 PM
rohan updated the diff for D6659: [native] Display both photos and videos in the media gallery on native.

Rebase on D6485

Fri, Feb 24, 1:50 PM
rohan updated the diff for D6531: [keyserver/lib] Set up the endpoints and responder for retrieving media.

Rebase on D6485

Fri, Feb 24, 1:49 PM