Page MenuHomePhabricator

rohan (Rohan Khanderia)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2022, 9:12 AM (82 w, 5 d)

Recent Activity

Dec 29 2023

rohan added a comment to D10497: [web] introduce community header button.

Just a question - do you plan to add the Roles community action here later as well?

Screenshot 2023-12-29 at 5.27.21 PM.png (1×1 px, 92 KB)

The roles + manage invite link community actions will live in this new community settings

Dec 29 2023, 2:31 PM
rohan added a comment to D10497: [web] introduce community header button.

Just a question - do you plan to add the Roles community action here later as well?

Dec 29 2023, 2:08 PM
rohan accepted D10497: [web] introduce community header button.
Dec 29 2023, 2:07 PM
rohan accepted D10496: [web] update colors in app directory modal to use enum option color family.
Dec 29 2023, 1:48 PM
rohan closed D10494: [lib/web/native] Show viewer in @-mentioning tooltip.
Dec 29 2023, 10:33 AM
rohan committed rCOMMe1798c21a902: [lib/web/native] Show viewer in @-mentioning tooltip (authored by rohan).
[lib/web/native] Show viewer in @-mentioning tooltip
Dec 29 2023, 10:33 AM
rohan abandoned D10495: [keyserver] Prevent self-mentions from pushing notifs to user.

Actually, I don't think we need this. I did some testing without this change and I'm not getting notifications for any self-mentions (I was logged into 'ashoat' on native)

Dec 29 2023, 10:09 AM
rohan published D10495: [keyserver] Prevent self-mentions from pushing notifs to user for review.
Dec 29 2023, 10:08 AM
rohan updated the summary of D10494: [lib/web/native] Show viewer in @-mentioning tooltip.
Dec 29 2023, 10:01 AM
rohan requested review of D10494: [lib/web/native] Show viewer in @-mentioning tooltip.
Dec 29 2023, 10:00 AM
rohan updated the diff for D10119: [web] Update existing checks on isDefault in role-actions-menu.reactjs.

Rebase

Dec 29 2023, 8:16 AM
rohan closed D10461: [lib] Include the rawChatName when constructing the chat mention search index.
Dec 29 2023, 8:14 AM
rohan committed rCOMM610946adb4c4: [lib] Include the rawChatName when constructing the chat mention search index (authored by rohan).
[lib] Include the rawChatName when constructing the chat mention search index
Dec 29 2023, 8:14 AM
rohan closed D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.
Dec 29 2023, 8:14 AM
rohan closed D10459: [lib] Pass in threadInfos into getChatMentionCandidates.
Dec 29 2023, 8:14 AM
rohan committed rCOMM9e834fe59da5: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName (authored by rohan).
[lib/web/native] Update ChatMentionCandidates type to include a rawChatName
Dec 29 2023, 8:14 AM
rohan committed rCOMMf0db11d1b4e7: [lib] Pass in threadInfos into getChatMentionCandidates (authored by rohan).
[lib] Pass in threadInfos into getChatMentionCandidates
Dec 29 2023, 8:14 AM
rohan closed D10458: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates.
Dec 29 2023, 8:14 AM
rohan committed rCOMM87b294ac9410: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates (authored by rohan).
[lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates
Dec 29 2023, 8:14 AM

Dec 28 2023

rohan accepted D10470: [web] introduce app list item.
Dec 28 2023, 11:09 AM
rohan added inline comments to D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.
Dec 28 2023, 10:59 AM
rohan updated the diff for D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.

Address feedback on removing unnecessary changes

Dec 28 2023, 10:57 AM
rohan added a comment to D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.
In D10460#302669, @inka wrote:

I understand the changes to getChatMentionCandidates / useChatMentionCandidatesObjAndUtils, because in the next diff you change useChatMentionSearchIndex, which is being passed data from useChatMentionCandidatesObjAndUtils. But what are the other changes for?

Dec 28 2023, 10:57 AM
rohan updated the diff for D10461: [lib] Include the rawChatName when constructing the chat mention search index.

Rebase

Dec 28 2023, 9:04 AM
rohan updated the diff for D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.

Address feedback (will respond to comments separately). Mainly factored out individual types and updated the code to reflect that

Dec 28 2023, 9:00 AM

Dec 27 2023

rohan closed D10467: [lib] Make useAncestorThreads more efficient.
Dec 27 2023, 4:26 PM
rohan committed rCOMM038aad4a2924: [lib] Make useAncestorThreads more efficient (authored by rohan).
[lib] Make useAncestorThreads more efficient
Dec 27 2023, 4:26 PM
rohan requested review of D10467: [lib] Make useAncestorThreads more efficient.
Dec 27 2023, 8:29 AM
rohan closed D10462: [lib] Fix typo in useMentionTypeaheadUserSuggestions.
Dec 27 2023, 7:50 AM
rohan committed rCOMMa37fd35408a6: [lib] Fix typo in useMentionTypeaheadUserSuggestions (authored by rohan).
[lib] Fix typo in useMentionTypeaheadUserSuggestions
Dec 27 2023, 7:50 AM
rohan accepted D10464: [lib] Pass isSocketConnected instead of connectionStatus to callServerEndpoint.
Dec 27 2023, 7:50 AM

Dec 26 2023

rohan requested review of D10462: [lib] Fix typo in useMentionTypeaheadUserSuggestions.
Dec 26 2023, 12:17 PM
rohan added a comment to D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.

Just wondering, are we supporting something like "@userone.eth and 0x12312321" matching a chat whose ENS-resolved name is "userone.eth and usertwo.eth"?

Dec 26 2023, 11:54 AM
rohan requested review of D10460: [lib/web/native] Update ChatMentionCandidates type to include a rawChatName.
Dec 26 2023, 11:01 AM
rohan requested review of D10461: [lib] Include the rawChatName when constructing the chat mention search index.
Dec 26 2023, 10:47 AM
rohan requested review of D10458: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates.
Dec 26 2023, 10:38 AM
rohan requested review of D10459: [lib] Pass in threadInfos into getChatMentionCandidates.
Dec 26 2023, 10:22 AM

Dec 23 2023

rohan added a comment to D10419: [web] ens resolve usernames in the reaction tooltip.

Is there some missing context here? It sounds like @rohan did some testing and things didn't work, but not sure what that testing was

Dec 23 2023, 6:55 PM

Dec 22 2023

rohan requested changes to D10419: [web] ens resolve usernames in the reaction tooltip.

Just requesting changes so its back in your queue. Let me know if my testing was missing something

Dec 22 2023, 5:17 PM
rohan closed D10432: [lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook.
Dec 22 2023, 10:28 AM
rohan closed D10407: [keyserver] Update sendPushNotif to detect mention for a ENS name.
Dec 22 2023, 10:28 AM
rohan committed rCOMM165d35ab1a3f: [lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook (authored by rohan).
[lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook
Dec 22 2023, 10:28 AM
rohan committed rCOMMaf4437e04876: [keyserver] Update sendPushNotif to detect mention for a ENS name (authored by rohan).
[keyserver] Update sendPushNotif to detect mention for a ENS name
Dec 22 2023, 10:28 AM
rohan closed D10389: [lib/web/native] Bold ENS names in user mentions.
Dec 22 2023, 10:28 AM
rohan closed D10388: [lib] Modify markdownUserMentionRegex to match ENS names as well.
Dec 22 2023, 10:28 AM
rohan committed rCOMMc97013f91e24: [lib] Modify markdownUserMentionRegex to match ENS names as well (authored by rohan).
[lib] Modify markdownUserMentionRegex to match ENS names as well
Dec 22 2023, 10:28 AM
rohan committed rCOMM87417b194198: [lib/web/native] Bold ENS names in user mentions (authored by rohan).
[lib/web/native] Bold ENS names in user mentions
Dec 22 2023, 10:28 AM
rohan closed D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
Dec 22 2023, 10:28 AM
rohan closed D10386: [native] Compute typeahead suggestions and matched strings outside the class component.
Dec 22 2023, 10:28 AM
rohan committed rCOMM7b51ac43d61c: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip (authored by rohan).
[lib/web/native] Show and search resolved ENS names in @ mentioning toolip
Dec 22 2023, 10:28 AM
rohan committed rCOMMe87f9df936e2: [native] Compute typeahead suggestions and matched strings outside the class… (authored by rohan).
[native] Compute typeahead suggestions and matched strings outside the class…
Dec 22 2023, 10:28 AM
rohan closed D10385: [native] Lift selectionState in chat input bar.
Dec 22 2023, 10:28 AM
rohan committed rCOMM5361aca8bd01: [native] Lift selectionState in chat input bar (authored by rohan).
[native] Lift selectionState in chat input bar
Dec 22 2023, 10:28 AM

Dec 21 2023

rohan requested review of D10432: [lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook.
Dec 21 2023, 1:55 PM
rohan added inline comments to D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
Dec 21 2023, 1:01 PM
rohan updated the diff for D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.

Address feedback

Dec 21 2023, 1:01 PM
rohan updated the diff for D10388: [lib] Modify markdownUserMentionRegex to match ENS names as well.

Move constant to account-utils.js with a comment

Dec 21 2023, 11:08 AM
rohan updated the diff for D10389: [lib/web/native] Bold ENS names in user mentions.

Revert the most recent update (updated the wrong diff)

Dec 21 2023, 11:07 AM
rohan updated the diff for D10389: [lib/web/native] Bold ENS names in user mentions.

Move constant to account-utils.js with a comment

Dec 21 2023, 11:05 AM
rohan added a comment to D10388: [lib] Modify markdownUserMentionRegex to match ENS names as well.
In D10388#301357, @inka wrote:

Looking at usages of oldValidUsernameRegexString I can see that it is used in oldValidUsernameRegex, which is used for something mention related on the keyserver. Should that be changed?

Dec 21 2023, 10:59 AM
rohan added a comment to D10389: [lib/web/native] Bold ENS names in user mentions.
In D10389#301405, @inka wrote:

getDefaultTextMessageRules is exactly the same on native and web, can we move it to lib?

Dec 21 2023, 8:45 AM
rohan updated the diff for D10389: [lib/web/native] Bold ENS names in user mentions.

Filter members without a role first, and construct a resolvedMembersMap and key by member.id

Dec 21 2023, 8:44 AM
rohan updated the diff for D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.

Remove console.log from testing

Dec 21 2023, 7:56 AM
rohan updated the diff for D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
  1. Rewrite typeaheadMatchedStrings on both web and native to avoid ternary
  2. Prevent search index from recalculating search results for each usersInThread
Dec 21 2023, 7:54 AM
rohan added inline comments to D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
Dec 21 2023, 7:54 AM

Dec 20 2023

rohan closed D10409: [lib] Memoize userinfos in usePotentialMemberItems.
Dec 20 2023, 7:02 AM
rohan committed rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems (authored by rohan).
[lib] Memoize userinfos in usePotentialMemberItems
Dec 20 2023, 7:02 AM

Dec 19 2023

rohan resigned from D10338: [web][native] Download invite link blob and use it as an override.

I'll leave this to the other reviewers as it seems like they have some more context/feedback here

Dec 19 2023, 9:10 PM
rohan requested review of D10409: [lib] Memoize userinfos in usePotentialMemberItems.
Dec 19 2023, 9:05 PM
rohan updated the diff for D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.

getUserMentionsCandidates --> useUserMentionsCandidates

Dec 19 2023, 9:00 PM
rohan added a comment to D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.

Memoization isn't just about avoiding the performance cost of rerunning the code. What's usually more important is avoiding regenerating non-primitives (like arrays and objects). By avoiding regenerating these, we reduce a bunch of expensive React renders.

Dec 19 2023, 8:53 PM
rohan updated the diff for D10407: [keyserver] Update sendPushNotif to detect mention for a ENS name.

Define userInfosWithENSNames in the correct scope

Dec 19 2023, 8:50 PM
rohan added inline comments to D10407: [keyserver] Update sendPushNotif to detect mention for a ENS name.
Dec 19 2023, 8:49 PM
rohan requested review of D10407: [keyserver] Update sendPushNotif to detect mention for a ENS name.
Dec 19 2023, 9:36 AM
rohan added a comment to D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.

You fixed it for web but not native (I actually didn't catch web – glad you did)

Oh sorry about that, I don't know what I was thinking to not do it for both even though it was called out here.

Separately, wonder if we just want to have a hook like useThreadChatMentionCandidates instead of memoizing the results of getUserMentionsCandidates in both places

Yeah that works better - though I was taking another look at getUserMentionsCandidates and I'm not sure if there's a use for memoization here. I don't think this is computationally expensive, but feel free to let me know if you disagree!

function getUserMentionsCandidates(
  threadInfo: ThreadInfo,
  parentThreadInfo: ?ThreadInfo,
): $ReadOnlyArray<RelativeMemberInfo> {
  if (threadInfo.type !== threadTypes.SIDEBAR) {
    return threadInfo.members;
  }
  if (parentThreadInfo) {
    return parentThreadInfo.members;
  }
  // This scenario should not occur unless the user logs out while looking at a
  // sidebar. In that scenario, the Redux store may be cleared before ReactNav
  // finishes transitioning away from the previous screen
  return [];
}
Dec 19 2023, 9:30 AM
rohan updated the diff for D10389: [lib/web/native] Bold ENS names in user mentions.
  1. Memoize hook return collection
  2. Remove members param from both web and native in rules.react.js
Dec 19 2023, 7:11 AM
rohan accepted D10391: [web] show total unreads in the navigation sidebar home button.
Dec 19 2023, 6:54 AM
rohan accepted D10360: [web] introduce community list.
Dec 19 2023, 6:53 AM
rohan updated the diff for D10386: [native] Compute typeahead suggestions and matched strings outside the class component.

Rebase

Dec 19 2023, 6:50 AM
rohan updated the diff for D10385: [native] Lift selectionState in chat input bar.

Use SetState type

Dec 19 2023, 6:49 AM

Dec 18 2023

rohan accepted D10362: [web] introduce account settings button for navigation sidebar.
Dec 18 2023, 2:00 PM
rohan accepted D10363: [web] introduce community creation button for navigation sidebar.
Dec 18 2023, 1:59 PM
rohan accepted D10364: [web] introduce navigation sidebar.
Dec 18 2023, 1:58 PM
rohan accepted D10390: [web] introduce unread badge component.
Dec 18 2023, 1:55 PM
rohan requested review of D10389: [lib/web/native] Bold ENS names in user mentions.
Dec 18 2023, 12:32 PM
rohan updated the diff for D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.

Memoize userMentionsCandidates

Dec 18 2023, 12:14 PM
rohan added inline comments to D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
Dec 18 2023, 12:12 PM
rohan updated the test plan for D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
Dec 18 2023, 12:07 PM
rohan requested review of D10388: [lib] Modify markdownUserMentionRegex to match ENS names as well.
Dec 18 2023, 11:46 AM
rohan requested review of D10387: [lib/web/native] Show and search resolved ENS names in @ mentioning toolip.
Dec 18 2023, 9:42 AM
rohan requested review of D10386: [native] Compute typeahead suggestions and matched strings outside the class component.
Dec 18 2023, 8:52 AM
rohan requested review of D10385: [native] Lift selectionState in chat input bar.
Dec 18 2023, 8:06 AM

Dec 15 2023

rohan added inline comments to D10359: [web] introduce community list item component.
Dec 15 2023, 9:05 PM
rohan accepted D10359: [web] introduce community list item component.
Dec 15 2023, 4:33 PM
rohan closed D10254: [lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex.
Dec 15 2023, 8:33 AM
rohan committed rCOMM63fe093f1cab: [lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex (authored by rohan).
[lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex
Dec 15 2023, 8:33 AM
rohan closed D10253: [web] Update AddUsersList to call useUserSearchIndex.
Dec 15 2023, 8:33 AM
rohan committed rCOMM275fee613bc1: [web] Update AddUsersList to call useUserSearchIndex (authored by rohan).
[web] Update AddUsersList to call useUserSearchIndex
Dec 15 2023, 8:33 AM
rohan closed D10252: [native] Update RelationshipList to call useUserSearchIndex.
Dec 15 2023, 8:33 AM
rohan committed rCOMM76e4ca6af009: [native] Update RelationshipList to call useUserSearchIndex (authored by rohan).
[native] Update RelationshipList to call useUserSearchIndex
Dec 15 2023, 8:33 AM