In D10497#303263, @ginsu wrote:

Just a question - do you plan to add the Roles community action here later as well?

The roles + manage invite link community actions will live in this new community settings

Just a question - do you plan to add the Roles community action here later as well?

Actually, I don't think we need this. I did some testing without this change and I'm not getting notifications for any self-mentions (I was logged into 'ashoat' on native)

Rebase

Address feedback on removing unnecessary changes

In D10460#302669, @inka wrote:

I understand the changes to getChatMentionCandidates / useChatMentionCandidatesObjAndUtils, because in the next diff you change useChatMentionSearchIndex, which is being passed data from useChatMentionCandidatesObjAndUtils. But what are the other changes for?

Rebase

Address feedback (will respond to comments separately). Mainly factored out individual types and updated the code to reflect that

In D10460#302348, @ashoat wrote:

Just wondering, are we supporting something like "@userone.eth and 0x12312321" matching a chat whose ENS-resolved name is "userone.eth and usertwo.eth"?

In D10419#302273, @ashoat wrote:

Is there some missing context here? It sounds like @rohan did some testing and things didn't work, but not sure what that testing was

Just requesting changes so its back in your queue. Let me know if my testing was missing something

Address feedback

Move constant to account-utils.js with a comment

Revert the most recent update (updated the wrong diff)

Move constant to account-utils.js with a comment

In D10388#301357, @inka wrote:

Looking at usages of oldValidUsernameRegexString I can see that it is used in oldValidUsernameRegex, which is used for something mention related on the keyserver. Should that be changed?

In D10389#301405, @inka wrote:

getDefaultTextMessageRules is exactly the same on native and web, can we move it to lib?

Filter members without a role first, and construct a resolvedMembersMap and key by member.id

Remove console.log from testing

1. Rewrite typeaheadMatchedStrings on both web and native to avoid ternary
2. Prevent search index from recalculating search results for each usersInThread

I'll leave this to the other reviewers as it seems like they have some more context/feedback here

getUserMentionsCandidates --> useUserMentionsCandidates

In D10387#301064, @ashoat wrote:

Memoization isn't just about avoiding the performance cost of rerunning the code. What's usually more important is avoiding regenerating non-primitives (like arrays and objects). By avoiding regenerating these, we reduce a bunch of expensive React renders.

Define userInfosWithENSNames in the correct scope

In D10387#300593, @ashoat wrote:

You fixed it for web but not native (I actually didn't catch web – glad you did)

Oh sorry about that, I don't know what I was thinking to not do it for both even though it was called out here.

Separately, wonder if we just want to have a hook like useThreadChatMentionCandidates instead of memoizing the results of getUserMentionsCandidates in both places

Yeah that works better - though I was taking another look at getUserMentionsCandidates and I'm not sure if there's a use for memoization here. I don't think this is computationally expensive, but feel free to let me know if you disagree!

function getUserMentionsCandidates(
  threadInfo: ThreadInfo,
  parentThreadInfo: ?ThreadInfo,
): $ReadOnlyArray<RelativeMemberInfo> {
  if (threadInfo.type !== threadTypes.SIDEBAR) {
    return threadInfo.members;
  }
  if (parentThreadInfo) {
    return parentThreadInfo.members;
  }
  // This scenario should not occur unless the user logs out while looking at a
  // sidebar. In that scenario, the Redux store may be cleared before ReactNav
  // finishes transitioning away from the previous screen
  return [];
}

1. Memoize hook return collection
2. Remove members param from both web and native in rules.react.js

Rebase

Use SetState type

Memoize userMentionsCandidates